feat(instance) Add a new wasm_instance.exported_functions field (improve function invocation time by 77%)
#70
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The idea is to cache the exported functions of an instance into an unordered map, so that we don't need to iterate over all the exports each time to find an exported function to invoke. `std::unordered_map` guarantees that reading an element is O(1).
Hywan
added
🎉 enhancement
|
bors try |
tryBuild succeeded |
`wasm_instance.exported_functions` is now a map from string to `wasm_exported_function`. This latter new structure holds the opaque pointer to `wasmer_export_func_t`. It also holds the sinature (inputs and outputs) of the exported function. The idea is to avoid collecting those information every time an exported function is invoked. It also avoids memory allocations.
|
bors try |
tryBuild succeeded |
|
The Before:
After:
It's 4.3 times faster to invoke a function (or 77% faster)! That's nice :-). |
Hywan
changed the title
wasm_instance.exported_functions field.wasm_instance.exported_functions field (improve function invocation time by 77%)
|
bors r+ |
bors bot
added a commit
that referenced
this pull request
Jul 10, 2019
70: feat(instance) Add a new `wasm_instance.exported_functions` field (improve function invocation time by 77%) r=Hywan a=Hywan The idea is to cache the exported functions of an instance into an unordered map, so that we don't need to iterate over all the exports each time to find an exported function to invoke. `std::unordered_map` guarantees that reading an element is O(1). Co-authored-by: Ivan Enderlin <ivan.enderlin@hoa-project.net>
Build succeeded |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The idea is to cache the exported functions of an instance into an
unordered map, so that we don't need to iterate over all the exports
each time to find an exported function to invoke.
std::unordered_mapguarantees that reading an element is O(1).