feat(extension) Use pre-build dynamic libraries #71
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
By using pre-build dynamic libraries (when a new Wasmer version is released), we simplify the build process of this project. Rust is no longer required to build the PHP extension.
Hywan
added
🎉 enhancement
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
It seems like `gcc` is already installed now.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
|
bors try |
tryBuild succeeded |
|
bors r+ |
bors bot
added a commit
that referenced
this pull request
Jul 10, 2019
71: feat(extension) Use pre-build dynamic libraries. r=Hywan a=Hywan By using pre-build dynamic libraries (when a new Wasmer version is released), we simplify the build process of this project. Rust is no longer required to build the PHP extension. Co-authored-by: Ivan Enderlin <ivan.enderlin@hoa-project.net>
Hywan
changed the title
Build succeeded |
Open
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
By using pre-build dynamic libraries (when a new Wasmer version is
released), we simplify the build process of this project. Rust is no
longer required to build the PHP extension.