Skip to content

Commit

Permalink
Add deny for unreachable patterns and unused unsafe
Browse files Browse the repository at this point in the history
  • Loading branch information
bjfish committed May 12, 2019
1 parent 8d2a08a commit 2aefa73
Show file tree
Hide file tree
Showing 15 changed files with 17 additions and 18 deletions.
2 changes: 1 addition & 1 deletion lib/clif-backend/src/lib.rs
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
#![deny(unused_imports, unused_variables)]
#![deny(unused_imports, unused_variables, unused_unsafe, unreachable_patterns)]

mod cache;
mod func_env;
Expand Down
2 changes: 1 addition & 1 deletion lib/emscripten/src/lib.rs
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
#![deny(unused_imports, unused_variables)]
#![deny(unused_imports, unused_variables, unused_unsafe, unreachable_patterns)]

#[macro_use]
extern crate wasmer_runtime_core;
Expand Down
2 changes: 1 addition & 1 deletion lib/llvm-backend/src/lib.rs
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
#![deny(unused_imports, unused_variables)]
#![deny(unused_imports, unused_variables, unused_unsafe, unreachable_patterns)]
#![cfg_attr(nightly, feature(unwind_attributes))]

mod backend;
Expand Down
2 changes: 1 addition & 1 deletion lib/middleware-common/src/lib.rs
Original file line number Diff line number Diff line change
@@ -1,3 +1,3 @@
#![deny(unused_imports, unused_variables)]
#![deny(unused_imports, unused_variables, unused_unsafe, unreachable_patterns)]

pub mod call_trace;
2 changes: 1 addition & 1 deletion lib/runtime-abi/src/lib.rs
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
#![deny(unused_imports, unused_variables)]
#![deny(unused_imports, unused_variables, unused_unsafe, unreachable_patterns)]

#[cfg(not(target_os = "windows"))]
#[macro_use]
Expand Down
2 changes: 1 addition & 1 deletion lib/runtime-c-api/src/lib.rs
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
#![deny(unused_imports, unused_variables)]
#![deny(unused_imports, unused_variables, unused_unsafe, unreachable_patterns)]

extern crate wasmer_runtime;
extern crate wasmer_runtime_core;
Expand Down
1 change: 0 additions & 1 deletion lib/runtime-core/src/codegen.rs
Original file line number Diff line number Diff line change
Expand Up @@ -35,7 +35,6 @@ impl fmt::Debug for InternalEvent {
InternalEvent::Breakpoint(_) => write!(f, "Breakpoint"),
InternalEvent::SetInternal(_) => write!(f, "SetInternal"),
InternalEvent::GetInternal(_) => write!(f, "GetInternal"),
_ => panic!("unknown event"),
}
}
}
Expand Down
2 changes: 1 addition & 1 deletion lib/runtime-core/src/lib.rs
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
#![deny(unused_imports, unused_variables)]
#![deny(unused_imports, unused_variables, unused_unsafe, unreachable_patterns)]
#![cfg_attr(nightly, feature(unwind_attributes))]

#[cfg(test)]
Expand Down
2 changes: 1 addition & 1 deletion lib/runtime/src/lib.rs
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
#![deny(unused_imports, unused_variables)]
#![deny(unused_imports, unused_variables, unused_unsafe, unreachable_patterns)]

//! Wasmer-runtime is a library that makes embedding WebAssembly
//! in your application easy, efficient, and safe.
Expand Down
8 changes: 4 additions & 4 deletions lib/singlepass-backend/src/codegen_x64.rs
Original file line number Diff line number Diff line change
Expand Up @@ -212,10 +212,10 @@ impl RunnableModule for X64ExecutionContext {
user_error: *mut Option<Box<dyn Any>>,
num_params_plus_one: Option<NonNull<c_void>>,
) -> bool {
let rm: &Box<dyn RunnableModule> = &unsafe { &*(*ctx).module }.runnable_module;
let execution_context = unsafe {
::std::mem::transmute_copy::<&dyn RunnableModule, &X64ExecutionContext>(&&**rm)
};
let rm: &Box<dyn RunnableModule> = &(&*(*ctx).module).runnable_module;
let execution_context =
::std::mem::transmute_copy::<&dyn RunnableModule, &X64ExecutionContext>(&&**rm);

let args = ::std::slice::from_raw_parts(
args,
num_params_plus_one.unwrap().as_ptr() as usize - 1,
Expand Down
2 changes: 1 addition & 1 deletion lib/singlepass-backend/src/lib.rs
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
#![deny(unused_imports, unused_variables)]
#![deny(unused_imports, unused_variables, unused_unsafe, unreachable_patterns)]
#![feature(proc_macro_hygiene)]

#[cfg(not(any(
Expand Down
2 changes: 1 addition & 1 deletion lib/wasi/src/lib.rs
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
#![deny(unused_imports, unused_variables)]
#![deny(unused_imports, unused_variables, unused_unsafe, unreachable_patterns)]

#[macro_use]
extern crate log;
Expand Down
2 changes: 1 addition & 1 deletion lib/win-exception-handler/src/lib.rs
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
#![deny(unused_imports, unused_variables)]
#![deny(unused_imports, unused_variables, unused_unsafe, unreachable_patterns)]

#[cfg(windows)]
mod exception_handling;
Expand Down
2 changes: 1 addition & 1 deletion src/bin/wasmer.rs
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
#![deny(unused_imports, unused_variables)]
#![deny(unused_imports, unused_variables, unused_unsafe, unreachable_patterns)]

extern crate structopt;

Expand Down
2 changes: 1 addition & 1 deletion src/lib.rs
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
#![deny(unused_imports, unused_variables)]
#![deny(unused_imports, unused_variables, unused_unsafe, unreachable_patterns)]

#[macro_use]
extern crate wasmer_runtime_core;
Expand Down

0 comments on commit 2aefa73

Please sign in to comment.