Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

wasmer 2.0.0: Invalid syntax in wax #2425

Closed
KSXGitHub opened this issue Jun 17, 2021 · 4 comments · Fixed by #2426
Closed

wasmer 2.0.0: Invalid syntax in wax #2425

KSXGitHub opened this issue Jun 17, 2021 · 4 comments · Fixed by #2426
Assignees
Labels
bug Something isn't working 📦 lib-cli About wasmer-cli

Comments

@KSXGitHub
Copy link

The wax file is not a valid shell file.

Steps to reproduce

  1. Go to the release page of 2.0.0 and download wasmer-linux-amd64.tar.gz.
  2. Extract the archive.
  3. Open bin/wax in a text editor.

Expected behavior

wax is a valid shell file:

#! /bin/bash
exec wapm execute "$@"

Actual behavior

wax's shebang is messed up:

#!/bin/bash\nwapm execute "$@"
@KSXGitHub KSXGitHub added the bug Something isn't working label Jun 17, 2021
@Hywan Hywan self-assigned this Jun 17, 2021
@Hywan Hywan added the 📦 lib-cli About wasmer-cli label Jun 17, 2021
@Hywan
Copy link
Contributor

Hywan commented Jun 17, 2021

Thank you for the bug report.

It's a difference between echo and echo -e in macOS and Linux. Let's fix that!

@KSXGitHub
Copy link
Author

It's a difference between echo and echo -e in macOS and Linux. Let's fix that!

You can just call echo twice.

@Hywan
Copy link
Contributor

Hywan commented Jun 17, 2021

Also yes, or just do this:

echo "hello
world"

@KSXGitHub
Copy link
Author

Also yes, or just do this:

echo "hello
world"

Because of indentation, it would actually be:

    # ...
    echo "hello
world"
    # ...

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working 📦 lib-cli About wasmer-cli
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants