Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Stack probing on AArch64 #2808

Open
Amanieu opened this issue Feb 25, 2022 · 4 comments
Open

Stack probing on AArch64 #2808

Amanieu opened this issue Feb 25, 2022 · 4 comments
Assignees
Labels
priority-low Low priority issue

Comments

@Amanieu
Copy link
Contributor

Amanieu commented Feb 25, 2022

Currently neither LLVM nor Cranelift implement stack probing on AArch64, which means that malicious Wasm code could potentially write to memory past the end of the stack.

Related:

@afonso360
Copy link

With bytecodealliance/wasmtime#5353 merged, Cranelift now supports inline stack probing.

@syrusakbary
Copy link
Member

Yup, we probably need to use this setting to enable in cranelift:

set enable_probestack=true
set probestack_strategy=inline

Copy link

stale bot commented Dec 1, 2023

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

@stale stale bot added the 🏚 stale Inactive issues or PR label Dec 1, 2023
@theduke
Copy link
Contributor

theduke commented Dec 1, 2023

Not stale.

@stale stale bot removed the 🏚 stale Inactive issues or PR label Dec 1, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
priority-low Low priority issue
Projects
None yet
Development

No branches or pull requests

5 participants