Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Aarch64 stackprobe #3756

Merged
merged 5 commits into from
Apr 8, 2023
Merged

Aarch64 stackprobe #3756

merged 5 commits into from
Apr 8, 2023

Conversation

syrusakbary
Copy link
Member

This PR addresses #2808 (only Cranelift) by using the inline stack option introduced in Cranelift 0.91.1

It also reenables most of the snapshot testing in macos

@ptitSeb
Copy link
Contributor

ptitSeb commented Apr 8, 2023

I suppose this test cranelift+aarch64 spec::skip_stack_guard_page can also be re-enable from ignores.txt

@syrusakbary
Copy link
Member Author

Done @ptitSeb , I think tests should be passing if you want to approve!

@syrusakbary syrusakbary merged commit 126d0d5 into master Apr 8, 2023
@syrusakbary syrusakbary deleted the aarch64-stackprobe branch April 8, 2023 07:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants