Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Broken on nightly because of ahash 0.7 (aka "update hashbrown") #4445

Closed
Manishearth opened this issue Feb 8, 2024 · 5 comments
Closed

Broken on nightly because of ahash 0.7 (aka "update hashbrown") #4445

Manishearth opened this issue Feb 8, 2024 · 5 comments
Assignees
Labels
bug Something isn't working priority-medium Medium priority issue
Milestone

Comments

@Manishearth
Copy link

ahash@0.7 is as of yesterday broken on Rust nightly, even if you do not choose to opt in to its nightly features, because it autoenables features in build.rs. See tkaitchuck/aHash#200.

This problem is fixed in ahash@0.8. However, this crate and its dependencies use ahash 0.7 via hashbrown@0.11 and hashbrown@0.12, used by object@0.28 and indexmap@1.9 respectively. object@0.32 and indexmap@2.0 are up to date.

Ideally wasmer should be updated to use the latest hashbrown.

I do have some alternate ways of solving this problem:

however I think it's worth updating hashbrown anyway.

This breaks older versions of wasmer as well, ideally these deps can be updated for the wasmer 2.x and 3.x series.

Thanks!

Copy link

linear bot commented Feb 8, 2024

@Manishearth
Copy link
Author

Manishearth commented Feb 8, 2024

This also implies fixing https://docs.rs/cranelift-egraph/latest/cranelift_egraph/

@theduke
Copy link
Contributor

theduke commented Feb 9, 2024

Thanks for the ping.
This will require some annoying dependency juggling because some dependencies are stuck on older versions to avoid duplicates.

DavidKorczynski pushed a commit to google/oss-fuzz that referenced this issue Feb 9, 2024
@Arshia001 Arshia001 added bug Something isn't working priority-medium Medium priority issue labels Feb 13, 2024
@Arshia001 Arshia001 modified the milestones: v4.3, v4.2.6 Feb 13, 2024
@theduke
Copy link
Contributor

theduke commented Feb 20, 2024

So it seems hashbrown has fixed this in 0.7.8, which means users can run cargo update and things will work.

We will also update the lockfile to have ahash@0.7.8 reflected in there.

@Arshia001 Arshia001 modified the milestones: v4.2.6, v4.2.7 Mar 3, 2024
@theduke
Copy link
Contributor

theduke commented Mar 19, 2024

Closing as fixed upstream.

@theduke theduke closed this as completed Mar 19, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working priority-medium Medium priority issue
Projects
None yet
Development

No branches or pull requests

4 participants