Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix stack overflow in Error's Display impl #204

Merged
merged 1 commit into from
Feb 25, 2019

Conversation

canndrew
Copy link
Contributor

The Display impl for Error calls itself in an infinite loop and overflows the stack. This PR fixes the issue.

@syrusakbary
Copy link
Member

Everything looks great!
Once the lint issue is fixed we should be good to merge 👍

@syrusakbary syrusakbary mentioned this pull request Feb 25, 2019
@syrusakbary syrusakbary merged commit ed70613 into wasmerio:master Feb 25, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants