fix appveyor installer and build #224
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
xmclark
force-pushed
the
fix/appveyor-installer
branch
from
b8e8630
to
b82fd7b
Compare
lachlansneff
reviewed
Mar 1, 2019
| @@ -33,7 +33,7 @@ impl Memory { | |||
|
|
|||
| let protect = protection.to_protect_const(); | |||
|
|
|||
| let ptr = unsafe { VirtualAlloc(ptr::null_mut(), size, MEM_RESERVE | MEM_COMMIT, protect) }; | |||
There was a problem hiding this comment.
This still works, even though we're not committing the memory?
syrusakbary
approved these changes
Mar 1, 2019
syrusakbary
approved these changes
Mar 1, 2019
syrusakbary
approved these changes
Mar 1, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR introduces a few changes. I reset and squashed some commits to make the intentions more clear. Here are some of the high level changes:
I have run these tests several times now, and feel confident that we should not have many more fluke failures. There is still more investigation needed...for example, spectests will fail if run singled threaded, but will pass if running multithreaded.