Update cranelift, impl low hanging fruit SIMD opcodes #2307
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MarkMcCaskey
requested review from
Hywan,
losfair,
nlewycky and
syrusakbary
as code owners
MarkMcCaskey
force-pushed
the
feature/update-clif-small-simd-improvement
branch
from
86d90a0
to
9e04e26
Compare
syrusakbary
approved these changes
May 12, 2021
|
bors r+ |
bors bot
added a commit
that referenced
this pull request
May 12, 2021
2307: Update cranelift, impl low hanging fruit SIMD opcodes r=syrusakbary a=MarkMcCaskey Bumps to clif 0.73 and implements the new SIMD opcodes that are 0 effort to do. (I thought i8x16popcnt would be zero effort too, but popcnt doesn't work on vectors in cranelift). Also updates `ignores.txt` due to the newly passing spectests Co-authored-by: Mark McCaskey <mark@wasmer.io> Co-authored-by: Syrus <me@syrusakbary.com>
|
Build failed: |
MarkMcCaskey
commented
May 13, 2021
|
Looks like we're getting some verifier errors with your changes, probably need to rewrite / fix those or disable them for now |
|
bors r+ |
bors bot
added a commit
that referenced
this pull request
May 13, 2021
2307: Update cranelift, impl low hanging fruit SIMD opcodes r=MarkMcCaskey a=MarkMcCaskey Bumps to clif 0.73 and implements the new SIMD opcodes that are 0 effort to do. (I thought i8x16popcnt would be zero effort too, but popcnt doesn't work on vectors in cranelift). Also updates `ignores.txt` due to the newly passing spectests Co-authored-by: Mark McCaskey <mark@wasmer.io> Co-authored-by: Syrus <me@syrusakbary.com> Co-authored-by: Mark McCaskey <5770194+MarkMcCaskey@users.noreply.github.com>
|
Build failed: |
|
bors try |
tryBuild failed: |
|
bors try |
tryBuild failed: |
|
bors try |
|
bors r+ |
tryBuild failed: |
bors bot
added a commit
that referenced
this pull request
May 14, 2021
2307: Update cranelift, impl low hanging fruit SIMD opcodes r=MarkMcCaskey a=MarkMcCaskey Bumps to clif 0.73 and implements the new SIMD opcodes that are 0 effort to do. (I thought i8x16popcnt would be zero effort too, but popcnt doesn't work on vectors in cranelift). Also updates `ignores.txt` due to the newly passing spectests Co-authored-by: Mark McCaskey <mark@wasmer.io> Co-authored-by: Syrus <me@syrusakbary.com> Co-authored-by: Mark McCaskey <5770194+MarkMcCaskey@users.noreply.github.com>
|
Canceled. |
|
bors r- |
|
bors r+ |
This was referenced May 15, 2021
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Bumps to clif 0.73 and implements the new SIMD opcodes that are 0 effort to do. (I thought i8x16popcnt would be zero effort too, but popcnt doesn't work on vectors in cranelift). Also updates
ignores.txtdue to the newly passing spectests