feat(runtime-c-api) Add an API to update vm::Ctx.data
#261
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This patch adds 2 functions for the runtime C API, respectively `wasmer_instance_context_data_set` and `wasmer_instance_context_data_get`. The goal is to modify the `vm::Ctx.data` field in the `runtime-core` library. This is required to pass dynamic data to imported functions for instance.
|
This looks good. Could you please add calling these functions to one of the C tests and assert the get matches what is set? |
|
Sure! |
Don't forget to free `context_data` :-).
bjfish
approved these changes
Mar 11, 2019
|
bors r+ |
bors bot
added a commit
that referenced
this pull request
Mar 11, 2019
261: feat(runtime-c-api) Add an API to update `vm::Ctx.data` r=Hywan a=Hywan This patch adds 2 functions for the runtime C API, respectively `wasmer_instance_context_data_set` and `wasmer_instance_context_data_get`. The goal is to modify the `vm::Ctx.data` field in the `runtime-core` library. Since all imported functions receive this context, that's the simplest way to pass dynamic data to them. Co-authored-by: Ivan Enderlin <ivan.enderlin@hoa-project.net>
Build failed |
|
bors retry |
bors bot
added a commit
that referenced
this pull request
Mar 12, 2019
261: feat(runtime-c-api) Add an API to update `vm::Ctx.data` r=Hywan a=Hywan This patch adds 2 functions for the runtime C API, respectively `wasmer_instance_context_data_set` and `wasmer_instance_context_data_get`. The goal is to modify the `vm::Ctx.data` field in the `runtime-core` library. Since all imported functions receive this context, that's the simplest way to pass dynamic data to them. Co-authored-by: Ivan Enderlin <ivan.enderlin@hoa-project.net> Co-authored-by: Syrus Akbary <me@syrusakbary.com>
Build failed |
…:Hywan/wasmer into feat-runtime-c-api-instance-context-data
|
bors retry |
bors bot
added a commit
that referenced
this pull request
Mar 12, 2019
261: feat(runtime-c-api) Add an API to update `vm::Ctx.data` r=Hywan a=Hywan This patch adds 2 functions for the runtime C API, respectively `wasmer_instance_context_data_set` and `wasmer_instance_context_data_get`. The goal is to modify the `vm::Ctx.data` field in the `runtime-core` library. Since all imported functions receive this context, that's the simplest way to pass dynamic data to them. Co-authored-by: Ivan Enderlin <ivan.enderlin@hoa-project.net> Co-authored-by: Syrus Akbary <me@syrusakbary.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This patch adds 2 functions for the runtime C API, respectively
wasmer_instance_context_data_setandwasmer_instance_context_data_get. The goal is to modify thevm::Ctx.datafield in theruntime-corelibrary.Since all imported functions receive this context, that's the
simplest way to pass dynamic data to them.