wasix: Remove Legacy thread-local System #3877
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
thread_local support in wasix was previously implemented via custom exports provided to modules. This has been refactored to a more efficient (guest-internal) implementation in both the wasix libc and the Rust fork. We kept the exports and related functionality in for a while to allow for modules to update, but now all the related functionality can safely be removed. Closes #3699
wasm-bus functionality was removed quite some time ago.
|
@dynamite-bud this is also relevant for you - you can remove the documentation for all the |
|
Unfortunately I had to remove one of the tests as the original source code was never kept - its |
john-sharratt
approved these changes
May 18, 2023
|
Included in #3906 . |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Remove deprecated thread_local functionality
thread_local support in wasix was previously implemented via custom
exports provided to modules.
This has been refactored to a more efficient (guest-internal)
implementation in both the wasix libc and the Rust fork.
We kept the exports and related functionality in for a while to allow for
modules to update, but now all the related code can safely be removed.
Closes #3699