Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

WASIX updates after superset changes #3906

Merged
merged 8 commits into from
May 24, 2023
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
409 changes: 205 additions & 204 deletions Cargo.lock

Large diffs are not rendered by default.

3 changes: 0 additions & 3 deletions lib/cli/src/commands/run.rs
Original file line number Diff line number Diff line change
Expand Up @@ -330,9 +330,6 @@ impl RunWithPathBuf {
if self.wasi.deny_multiple_wasi_versions {
let version_list = get_version_list(&wasi_versions);
bail!("Found more than 1 WASI version in this module ({}) and `--deny-multiple-wasi-versions` is enabled.", version_list);
} else if !self.wasi.allow_multiple_wasi_versions {
let version_list = get_version_list(&wasi_versions);
warning!("Found more than 1 WASI version in this module ({}). If this is intentional, pass `--allow-multiple-wasi-versions` to suppress this warning.", version_list);
}
}

Expand Down
4 changes: 0 additions & 4 deletions lib/cli/src/commands/run/wasi.rs
Original file line number Diff line number Diff line change
Expand Up @@ -101,10 +101,6 @@ pub struct Wasi {
#[clap(long)]
pub http_client: bool,

/// Allow WASI modules to import multiple versions of WASI without a warning.
#[clap(long = "allow-multiple-wasi-versions")]
pub allow_multiple_wasi_versions: bool,

/// Require WASI modules to only import 1 version of WASI.
#[clap(long = "deny-multiple-wasi-versions")]
pub deny_multiple_wasi_versions: bool,
Expand Down
73 changes: 7 additions & 66 deletions lib/wasi-types/schema/wasi/typenames.wit
Original file line number Diff line number Diff line change
Expand Up @@ -254,52 +254,6 @@ enum errno {
unknown,
}

enum bus-errno {
// TODO: wit appears to not have support for enum tag types
//(@witx tag u32)

/// No error occurred. Call completed successfully.
success,
/// Failed during serialization
ser,
/// Failed during deserialization
des,
/// Invalid WAPM process
wapm,
/// Failed to fetch the WAPM process
fetch,
/// Failed to compile the WAPM process
compile,
/// Invalid ABI
abi,
/// Call was aborted
aborted,
/// Bad handle
badhandle,
/// Invalid topic
topic,
/// Invalid callback
badcb,
/// Call is unsupported
unsupported,
/// Bad request
badrequest,
/// Access denied
denied,
/// Internal error has occured
internal,
/// Memory allocation failed
alloc,
/// Invocation has failed
invoke,
/// Already consumed
consumed,
/// Memory access violation
memviolation,
/// Some other unhandled error. If you see this, it's probably a bug.
unknown,
}

/// File descriptor rights, determining which actions may be performed.
flags rights {
// TODO: wit doesnt appear to support repr
Expand Down Expand Up @@ -422,8 +376,10 @@ enum filetype {
socket-stream,
/// The file refers to a symbolic link inode.
symbolic-link,
/// The file descriptor or file refers to a FIFO.
fifo,
/// The file descriptor or file refers to a raw socket.
socket-raw,
/// The file descriptor or file refers to a sequential packet socket.
socket-seqpacket
}

/// A directory entry, snapshot0 version.
Expand Down Expand Up @@ -695,8 +651,9 @@ record subscription-fs-readwrite {
// }

enum socktype {
dgram,
unknown,
%stream,
dgram,
raw,
seqpacket,
}
Expand Down Expand Up @@ -798,26 +755,12 @@ record tty {
line-buffered: bool,
}

type bid = u32

type cid = u64

/// __wasi_option_t
enum option-tag {
none,
some,
}

record option-bid {
tag: option-tag,
bid: bid
}

record option-cid {
tag: option-tag,
cid: cid
}

record option-pid {
tag: option-tag,
pid: pid
Expand All @@ -828,8 +771,6 @@ record option-fd {
fd: fd
}

type exit-code = errno

type event-fd-flags = u16

record prestat-u-dir {
Expand Down Expand Up @@ -1142,7 +1083,7 @@ record option-timestamp {
}

enum signal {
sigunknown,
signone,
sighup,
sigint,
sigquit,
Expand Down