Move rewind buffer to after TLS area if it's at the bottom of the stack #4639
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This PR is a draft because I'm not done testing the changes out yet, will mark ready once I'm confident nothing is broken. |
Arshia001
force-pushed
the
fix/stack-checkpoint-overwrites-thread-locals
branch
from
b078771
to
83020eb
Compare
theduke
reviewed
May 7, 2024
theduke
approved these changes
May 7, 2024
john-sharratt
approved these changes
May 7, 2024
| @@ -870,6 +870,21 @@ pub(crate) fn get_stack_upper(env: &WasiEnv) -> u64 { | |||
| env.layout.stack_upper | |||
| } | |||
|
|
|||
| fn get_unwind_buffer_start(env: &WasiEnv) -> u64 { | |||
There was a problem hiding this comment.
I would have just put this in the WasuMemoryLayout struct Impl section instead
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes the issue of unwind/rewind overwriting TLS if it's on the bottom of the stack.
Note, there is a breaking change to the journal archive format.