feat(cli/package-tag): Manifest is not mandatory anymore while tagging #4848
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
syrusakbary
approved these changes
Jun 17, 2024
ayys
reviewed
Jun 17, 2024
ayys
reviewed
Jun 17, 2024
ayys
approved these changes
Jun 18, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR tries to solve #4672 and #4788.
This involves necessary breaking changes to the
tagcommand which we introduced in 4.3.0, as before we hadand, in this PR, it should now be
So, keeping both args (path and namespace) to maintain backwards compatibility would make this PR nonsensical - as it would still need a manifest. Users can still specify a manifest to draw the info regarding the package to tag from with the
--package-pathflag.In general, this PR still keeps the concept of manifest in the tagging logic. This, of course, is to keep a minimum of backwards compatibility, but also because some package values - such as description, readme and so forth - are better read off of the manifest, rather than passed via flag from the user.