Add builder API for WasiState #850
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
syrusakbary
approved these changes
Oct 1, 2019
|
bors r+ |
bors bot
added a commit
that referenced
this pull request
Oct 1, 2019
850: Add builder API for WasiState r=MarkMcCaskey a=MarkMcCaskey Nicer to use and it checks for errors! # Review - [x] Add a short description of the the change to the CHANGELOG.md file Co-authored-by: Mark McCaskey <mark@wasmer.io> Co-authored-by: Mark McCaskey <markmccaskey@users.noreply.github.com>
Build failed
|
syrusakbary
reviewed
Oct 1, 2019
lib/wasi/src/state/builder.rs
Outdated
Comment on lines
6
to
30
| /// Creates an empty [`WasiStateBuilder`]. | ||
| pub fn create_wasi_state() -> WasiStateBuilder { | ||
| WasiStateBuilder::default() | ||
| } | ||
|
|
||
| /// Type for building an instance of [`WasiState`] | ||
| /// | ||
| /// Usage: | ||
| /// | ||
| /// ``` | ||
| /// # use wasmer_wasi::state::create_wasi_state; | ||
| /// create_wasi_state() | ||
| /// .env(b"HOME", "/home/home".to_string()) | ||
| /// .arg("--help") | ||
| /// .envs({ let mut hm = std::collections::HashMap::new(); | ||
| /// hm.insert("COLOR_OUTPUT", "TRUE"); | ||
| /// hm.insert("PATH", "/usr/bin"); | ||
| /// hm | ||
| /// }) | ||
| /// .args(&["--verbose", "list"]) | ||
| /// .preopen_dir("src") | ||
| /// .map_dir("dot", ".") | ||
| /// .build() | ||
| /// .unwrap(); | ||
| /// ``` |
There was a problem hiding this comment.
I was thinking that perhaps this API might be simpler? (removing crate_wasi_state and renaming WasiStateBuilder to WASICommand )
use wasmer_wasi::WASICommand;
WASICommand::new("")
.env(b"HOME", "/home/home".to_string())
.arg("--help")
.envs({ let mut hm = std::collections::HashMap::new();
hm.insert("COLOR_OUTPUT", "TRUE");
hm.insert("PATH", "/usr/bin");
hm
})
.args(&["--verbose", "list"])
.preopen_dir("src")
.map_dir("dot", ".")
.build()
.unwrap();format with 1.37
MarkMcCaskey
force-pushed
the
feature/builder-api-for-wasi-state
branch
from
364b585
to
5185f12
Compare
|
I'm not implementing the command interface now. I do like it though and it's something I want to revisit. But I think it may not fit in this PR. We could have a general |
|
bors r+ |
bors bot
added a commit
that referenced
this pull request
Oct 2, 2019
850: Add builder API for WasiState r=MarkMcCaskey a=MarkMcCaskey Nicer to use and it checks for errors! # Review - [x] Add a short description of the the change to the CHANGELOG.md file Co-authored-by: Mark McCaskey <mark@wasmer.io> Co-authored-by: Mark McCaskey <markmccaskey@users.noreply.github.com>
Canceled |
|
bors r+ |
bors bot
added a commit
that referenced
this pull request
Oct 2, 2019
850: Add builder API for WasiState r=MarkMcCaskey a=MarkMcCaskey Nicer to use and it checks for errors! # Review - [x] Add a short description of the the change to the CHANGELOG.md file Co-authored-by: Mark McCaskey <mark@wasmer.io> Co-authored-by: Mark McCaskey <markmccaskey@users.noreply.github.com>
MarkMcCaskey
force-pushed
the
feature/builder-api-for-wasi-state
branch
from
cbdfd87
to
3c47563
Compare
Canceled |
|
bors r+ |
bors bot
added a commit
that referenced
this pull request
Oct 2, 2019
850: Add builder API for WasiState r=MarkMcCaskey a=MarkMcCaskey Nicer to use and it checks for errors! # Review - [x] Add a short description of the the change to the CHANGELOG.md file Co-authored-by: Mark McCaskey <mark@wasmer.io> Co-authored-by: Mark McCaskey <markmccaskey@users.noreply.github.com>
Build failed
|
Fix typo Fix debug issue
MarkMcCaskey
force-pushed
the
feature/builder-api-for-wasi-state
branch
from
3c47563
to
afbde49
Compare
|
bors retry |
bors bot
added a commit
that referenced
this pull request
Oct 2, 2019
850: Add builder API for WasiState r=MarkMcCaskey a=MarkMcCaskey Nicer to use and it checks for errors! # Review - [x] Add a short description of the the change to the CHANGELOG.md file Co-authored-by: Mark McCaskey <mark@wasmer.io> Co-authored-by: Mark McCaskey <markmccaskey@users.noreply.github.com>
Build succeeded
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Nicer to use and it checks for errors!
Review