Basic stack pooling allocator #169
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dhil
force-pushed
the
wasmfx-stack-pooling2
branch
from
cc28fba
to
60d8ecd
Compare
dhil
force-pushed
the
wasmfx-stack-pooling2
branch
5 times, most recently
from
309f45e
to
cf6f1e9
Compare
frank-emrich
approved these changes
May 21, 2024
crates/wasmtime/src/runtime/vm/instance/allocator/wasmfx_allocator.rs
Outdated
Show resolved
Hide resolved
crates/wasmtime/src/runtime/vm/instance/allocator/wasmfx_allocator.rs
Outdated
Show resolved
Hide resolved
crates/wasmtime/src/runtime/vm/instance/allocator/wasmfx_allocator.rs
Outdated
Show resolved
Hide resolved
crates/wasmtime/src/runtime/vm/instance/allocator/wasmfx_allocator.rs
Outdated
Show resolved
Hide resolved
…blem was that the runtime attempted to reclaim pooled stacks using free...
dhil
force-pushed
the
wasmfx-stack-pooling2
branch
from
cf6f1e9
to
852de67
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This patch adds a basic stack pooling allocator for WasmFX stacks. It is gated behind a feature flag
wasmfx_pooling_allocator, which is disabled by default.Currently, the pooling allocator works only with the baseline implementation as the optimized implementation segfaults (Frank, I probably need your help to figure out why). By default stacks are safe, meaning they have a page guard attached. The old unsafe stacks are gated behind the feature flagunsafe_wasmfx_stacks.In addition, this patch also adds missing WasmFX features to
wasmtime-c-apiandwasmtime-c-api-impl.Merge after #168.
Resolves #91. Resolves #26.