Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve Wasmi and Wasmtime API mirroring with renamings #1011

Merged
merged 13 commits into from May 2, 2024

Conversation

Robbepop
Copy link
Collaborator

@Robbepop Robbepop commented May 2, 2024

  • Config::engine_limits method -> enforced_limits
  • Value enum -> Val
  • ValueType enum -> ValType
  • UntypedValue struct -> UntypedVal
  • WasmType trait -> WasmTy
  • AsContext::UserState assoc. type -> Data

this improves mirroring between Wasmi and Wasmtime.
Following steps with Value to Val renaming.
Following Value to Val renaming.
Improves Wasmi and Wasmtime mirroring.
Improves Wasmi and Wasmtime mirroring.
Copy link

codecov bot commented May 2, 2024

Codecov Report

Attention: Patch coverage is 83.42665% with 148 lines in your changes are missing coverage. Please review.

Project coverage is 80.68%. Comparing base (232b95c) to head (c400242).

Files Patch % Lines
crates/wasmi/src/engine/translator/visit.rs 38.12% 86 Missing ⚠️
crates/cli/src/display.rs 35.71% 9 Missing ⚠️
crates/cli/src/utils.rs 0.00% 7 Missing ⚠️
crates/wasmi/src/engine/executor/instrs.rs 46.15% 7 Missing ⚠️
.../wasmi/src/engine/translator/tests/display_wasm.rs 50.00% 7 Missing ⚠️
crates/wasmi/src/table/mod.rs 54.54% 5 Missing ⚠️
crates/cli/src/main.rs 0.00% 3 Missing ⚠️
crates/wasmi/src/global.rs 72.72% 3 Missing ⚠️
crates/wasmi/src/engine/bytecode/provider.rs 0.00% 2 Missing ⚠️
crates/wasmi/src/engine/executor/instrs/binary.rs 0.00% 2 Missing ⚠️
... and 13 more
Additional details and impacted files
@@            Coverage Diff             @@
##           master    #1011      +/-   ##
==========================================
+ Coverage   80.65%   80.68%   +0.03%     
==========================================
  Files         269      269              
  Lines       24813    24775      -38     
==========================================
- Hits        20012    19990      -22     
+ Misses       4801     4785      -16     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@Robbepop Robbepop changed the title Improve Wasmi and Wasmtime API mirroring Improve Wasmi and Wasmtime API mirroring with renamings May 2, 2024
@Robbepop Robbepop merged commit 67d33c1 into master May 2, 2024
17 checks passed
@Robbepop Robbepop deleted the rf-improve-api-mirroring branch May 2, 2024 09:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant