Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve memory reservations in ModuleBuilder #1032

Merged
merged 2 commits into from
May 12, 2024
Merged

Conversation

Robbepop
Copy link
Member

@Robbepop Robbepop commented May 12, 2024

This should optimize ModuleBuilder::finish and generally the building process of Wasm modules.

Locally I can see some minor 2-5% performance wins especially for the lazy translation test cases where the impact is especially visible.

Copy link

codecov bot commented May 12, 2024

Codecov Report

Attention: Patch coverage is 93.33333% with 1 lines in your changes are missing coverage. Please review.

Project coverage is 80.83%. Comparing base (26ea8ad) to head (3861ae3).
Report is 1 commits behind head on master.

Files Patch % Lines
crates/wasmi/src/module/builder.rs 93.33% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master    #1032      +/-   ##
==========================================
- Coverage   80.83%   80.83%   -0.01%     
==========================================
  Files         269      269              
  Lines       24803    24817      +14     
==========================================
+ Hits        20049    20060      +11     
- Misses       4754     4757       +3     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@Robbepop Robbepop merged commit 3ea4ddb into master May 12, 2024
17 of 18 checks passed
@Robbepop Robbepop deleted the rf-opt-module-builder branch May 12, 2024 21:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant