Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

engine/config: fix wasm_tail_call and wasm_extended_const docs #1042

Merged
merged 1 commit into from
May 22, 2024

Conversation

airwoodix
Copy link
Contributor

The defaults for Config::tail_call and Config::extended_const were changed in #1031 but the change wasn't reflected in the documentation.

Also fix the markdown reference for the extended-const proposal link.

@Robbepop
Copy link
Member

@airwoodix great catch! Thanks for the fix. :) Will merge once CI is green.

Copy link

codecov bot commented May 22, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 80.86%. Comparing base (485a30a) to head (3b2d570).
Report is 1 commits behind head on master.

Additional details and impacted files
@@           Coverage Diff           @@
##           master    #1042   +/-   ##
=======================================
  Coverage   80.86%   80.86%           
=======================================
  Files         271      271           
  Lines       24896    24896           
=======================================
  Hits        20132    20132           
  Misses       4764     4764           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@Robbepop Robbepop merged commit 6478f2e into wasmi-labs:master May 22, 2024
18 checks passed
@airwoodix airwoodix deleted the fix-some-engine-config-docs branch May 22, 2024 13:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants