Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix local.set miscompilation with propagating values more generally #1054

Merged
merged 2 commits into from
Jun 3, 2024

Conversation

Robbepop
Copy link
Member

@Robbepop Robbepop commented Jun 3, 2024

Closes #1051.

Copy link

codecov bot commented Jun 3, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 80.72%. Comparing base (14118e4) to head (6cf8501).

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #1054      +/-   ##
==========================================
+ Coverage   80.71%   80.72%   +0.01%     
==========================================
  Files         268      268              
  Lines       24990    25006      +16     
==========================================
+ Hits        20170    20186      +16     
  Misses       4820     4820              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@Robbepop Robbepop merged commit 04c3f3c into master Jun 3, 2024
18 checks passed
@Robbepop Robbepop deleted the rf-fix-local.set-bug-v2 branch June 3, 2024 11:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Redundant local.tee instruction with overwriting semantics causes miscompilation
1 participant