Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: minor improve and remove unused traits impls for f32/f64 #543

Merged
merged 5 commits into from Oct 31, 2022

Conversation

yjhmelody
Copy link
Contributor

@yjhmelody yjhmelody commented Oct 31, 2022

And do code fmt for traits impl orders.

crates/wasmi/src/lib.rs Outdated Show resolved Hide resolved
@paritytech-cicd-pr
Copy link

BENCHMARKS

NATIVEWASMTIME
BENCHMARKMASTERPRDIFFMASTERPRDIFFWASMTIME OVERHEAD
execute/
bare_call_0
1.27ms 1.30ms 🔴 1.88% 1.12ms 1.09ms 🟢 -3.00% 🟢 -16%
execute/
bare_call_0/typed
710.72µs 749.99µs 🔴 6.28% 541.65µs 540.81µs ⚪ -0.24% 🟢 -28%
execute/
bare_call_1
1.39ms 1.42ms 🔴 2.58% 1.35ms 1.35ms 🟢 -0.10% 🟢 -5%
execute/
bare_call_16
2.97ms 3.00ms ⚪ 1.80% 5.00ms 5.00ms 🟢 0.09% 🟡 67%
execute/
bare_call_16/typed
1.29ms 1.30ms ⚪ 0.97% 2.31ms 2.28ms 🟢 -1.76% 🟡 75%
execute/
bare_call_1/typed
800.88µs 852.73µs 🔴 6.55% 869.94µs 864.92µs ⚪ -0.81% 🟢 1%
execute/
bare_call_4
1.78ms 1.80ms ⚪ 2.12% 2.16ms 2.16ms 🟢 0.12% 🟢 20%
execute/
bare_call_4/typed
893.27µs 887.96µs ⚪ -0.65% 998.64µs 982.08µs 🟢 -1.69% 🟢 11%
execute/
br_table
938.17µs 952.10µs 🔴 1.41% 1.10ms 1.09ms ⚪ -0.21% 🟢 15%
execute/
count_until
1.20ms 903.17µs 🟢 -24.64% 2.21ms 2.21ms ⚪ -0.03% 🔴 144%
execute/
factorial_iterative
365.05µs 364.89µs ⚪ 0.00% 903.19µs 902.98µs ⚪ -0.09% 🔴 147%
execute/
factorial_recursive
711.40µs 710.85µs ⚪ -0.08% 1.44ms 1.44ms ⚪ -0.02% 🔴 103%
execute/
fib_iterative
1.79ms 1.79ms ⚪ -0.02% 4.91ms 4.91ms ⚪ -0.23% 🔴 174%
execute/
fib_recursive
6.75ms 6.76ms ⚪ 0.15% 13.52ms 13.58ms ⚪ 0.38% 🔴 101%
execute/
global_bump
1.38ms 1.38ms ⚪ 0.13% 3.36ms 3.35ms ⚪ -0.28% 🔴 143%
execute/
global_const
999.52µs 1.00ms ⚪ 0.10% 2.51ms 2.52ms ⚪ 0.16% 🔴 151%
execute/
host_calls
32.38µs 32.38µs ⚪ 0.02% 44.69µs 44.74µs ⚪ 0.10% 🟢 38%
execute/
memory_fill
1.55ms 1.55ms ⚪ 0.05% 4.08ms 4.07ms ⚪ -0.26% 🔴 162%
execute/
memory_sum
1.55ms 1.55ms ⚪ -0.03% 4.06ms 4.05ms ⚪ -0.08% 🔴 161%
execute/
memory_vec_add
3.06ms 4.89ms 🔴 59.70% 8.13ms 8.03ms ⚪ -1.01% 🟡 64%
execute/
recursive_is_even
1.30ms 1.29ms ⚪ -0.82% 2.57ms 2.49ms 🟢 -3.23% 🟡 93%
execute/
recursive_ok
166.97µs 167.24µs ⚪ 0.08% 343.74µs 345.02µs ⚪ 0.17% 🔴 106%
execute/
recursive_scan
209.01µs 213.20µs 🔴 2.03% 439.92µs 438.20µs ⚪ -0.48% 🔴 106%
execute/
recursive_trap
16.42µs 16.25µs ⚪ -1.29% 34.30µs 33.93µs ⚪ -1.15% 🔴 109%
execute/
regex_redux
678.60µs 664.76µs 🟢 -2.03% 1.45ms 1.45ms ⚪ -0.13% 🔴 118%
execute/
rev_complement
583.99µs 583.93µs ⚪ 0.01% 1.43ms 1.43ms ⚪ -0.04% 🔴 146%
execute/
tiny_keccak
462.06µs 475.46µs 🔴 2.96% 1.29ms 1.32ms 🔴 2.64% 🔴 178%
execute/
trunc_f2i
1.01ms 1.02ms 🔴 1.46% 2.45ms 2.44ms ⚪ -0.28% 🔴 138%
instantiate/
wasm_kernel
72.09µs 71.16µs ⚪ 0.25% 94.88µs 94.64µs ⚪ -0.28% 🟢 33%
translate/
wasm_kernel
4.18ms 4.17ms ⚪ -0.10% 8.03ms 7.79ms 🟢 -3.46% 🟡 87%

Link to pipeline

Copy link
Collaborator

@Robbepop Robbepop left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM Thanks for the follow-up.

@Robbepop Robbepop merged commit f2e70d2 into wasmi-labs:master Oct 31, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants