Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

wasmi_cli: Support fuel metering #679

Merged
merged 1 commit into from Feb 14, 2023
Merged

wasmi_cli: Support fuel metering #679

merged 1 commit into from Feb 14, 2023

Conversation

Robbepop
Copy link
Collaborator

No description provided.

@paritytech-cicd-pr
Copy link

BENCHMARKS

NATIVEWASMTIME
BENCHMARKMASTERPRDIFFMASTERPRDIFFWASMTIME OVERHEAD
execute/
bare_call_0
1.45ms 1.45ms ⚪ 0.22% 1.30ms 1.22ms 🟢 -5.87% 🟢 -15%
execute/
bare_call_0/typed
1.04ms 1.04ms ⚪ -0.36% 860.58µs 840.19µs 🟢 -2.22% 🟢 -20%
execute/
bare_call_1
1.49ms 1.52ms 🔴 1.73% 1.49ms 1.47ms 🔴 -1.02% 🟢 -3%
execute/
bare_call_16
2.34ms 2.33ms ⚪ -0.91% 4.17ms 4.17ms ⚪ 0.04% 🟡 79%
execute/
bare_call_16/typed
1.60ms 1.60ms ⚪ -0.54% 2.40ms 2.38ms ⚪ -0.72% 🟢 49%
execute/
bare_call_1/typed
1.16ms 1.16ms ⚪ -0.19% 1.29ms 1.31ms 🔴 1.62% 🟢 13%
execute/
bare_call_4
1.67ms 1.77ms 🔴 5.61% 2.02ms 1.96ms 🟢 -3.03% 🟢 11%
execute/
bare_call_4/typed
1.16ms 1.16ms ⚪ -0.05% 1.41ms 1.36ms 🟢 -4.04% 🟢 17%
execute/
br_table
1.23ms 1.18ms 🟢 -3.34% 1.48ms 1.47ms ⚪ -0.82% 🟢 24%
execute/
count_until
709.94µs 710.33µs ⚪ 0.09% 2.31ms 2.29ms ⚪ -0.40% 🔴 222%
execute/
factorial_iterative
318.86µs 319.08µs ⚪ 0.07% 955.66µs 953.45µs ⚪ -0.35% 🔴 199%
execute/
factorial_recursive
650.01µs 650.36µs ⚪ 0.03% 1.35ms 1.30ms 🟢 -3.79% 🟡 100%
execute/
fib_iterative
1.42ms 1.42ms ⚪ 0.21% 5.14ms 5.15ms ⚪ 0.12% 🔴 263%
execute/
fib_recursive
5.92ms 6.08ms 🔴 2.79% 12.00ms 11.65ms 🟢 -2.99% 🟡 92%
execute/
global_bump
1.05ms 1.05ms ⚪ 0.55% 2.64ms 2.65ms ⚪ 0.13% 🔴 152%
execute/
global_const
709.89µs 710.01µs ⚪ 0.00% 2.40ms 2.43ms ⚪ 1.43% 🔴 242%
execute/
host_calls
27.68µs 27.85µs ⚪ 0.51% 45.53µs 43.11µs 🟢 -5.37% 🟡 55%
execute/
memory_fill
1.30ms 1.30ms ⚪ 0.02% 4.17ms 4.16ms ⚪ -0.11% 🔴 220%
execute/
memory_sum
1.30ms 1.30ms ⚪ 0.00% 4.14ms 4.14ms ⚪ -0.20% 🔴 219%
execute/
memory_vec_add
2.47ms 2.47ms ⚪ 0.03% 7.80ms 7.81ms ⚪ -0.09% 🔴 216%
execute/
recursive_is_even
1.16ms 1.12ms ⚪ -2.03% 2.39ms 2.31ms 🟢 -3.02% 🔴 107%
execute/
recursive_ok
158.59µs 157.04µs ⚪ -0.46% 305.54µs 308.08µs ⚪ 1.15% 🟡 96%
execute/
recursive_scan
184.06µs 187.62µs ⚪ 1.38% 370.62µs 372.40µs ⚪ 0.92% 🟡 98%
execute/
recursive_trap
15.20µs 15.14µs ⚪ -0.45% 30.87µs 31.64µs ⚪ 2.04% 🔴 109%
execute/
regex_redux
535.84µs 534.80µs ⚪ -0.33% 1.40ms 1.38ms 🟢 -1.80% 🔴 158%
execute/
rev_complement
480.59µs 484.12µs ⚪ 0.72% 1.42ms 1.42ms ⚪ 0.11% 🔴 194%
execute/
tiny_keccak
344.11µs 344.24µs ⚪ 0.06% 1.15ms 1.15ms ⚪ 0.11% 🔴 233%
execute/
trunc_f2i
694.84µs 694.90µs ⚪ 0.00% 2.15ms 2.15ms ⚪ 0.07% 🔴 209%
instantiate/
wasm_kernel
64.49µs 61.13µs 🟢 -5.62% 69.41µs 70.85µs 🔴 2.93% 🟢 16%
translate/
erc1155
235.76µs 234.90µs ⚪ -0.25% 455.76µs 462.01µs 🔴 1.56% 🟡 97%
translate/
erc20
114.20µs 113.61µs ⚪ -0.63% 219.90µs 223.50µs 🔴 1.53% 🟡 97%
translate/
erc721
161.80µs 161.09µs ⚪ -0.23% 321.19µs 323.81µs ⚪ 0.90% 🔴 101%
translate/
spidermonkey
0.00ns 0.00ns ⚪ -0.07% 0.00ns 0.00ns ⚪ 0.26% 🟢 0%
translate/
wasm_kernel
4.06ms 4.06ms ⚪ -0.13% 8.32ms 8.34ms ⚪ 0.15% 🔴 106%

Link to pipeline

@codecov-commenter
Copy link

Codecov Report

Merging #679 (da8b4fe) into master (0a14f20) will decrease coverage by 0.16%.
The diff coverage is 0.00%.

@@            Coverage Diff             @@
##           master     #679      +/-   ##
==========================================
- Coverage   81.36%   81.20%   -0.16%     
==========================================
  Files         100      100              
  Lines        8423     8439      +16     
==========================================
  Hits         6853     6853              
- Misses       1570     1586      +16     
Impacted Files Coverage Δ
crates/cli/src/args.rs 0.00% <0.00%> (ø)
crates/cli/src/context.rs 0.00% <0.00%> (ø)
crates/cli/src/main.rs 0.00% <0.00%> (ø)

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@Robbepop Robbepop merged commit 075c410 into master Feb 14, 2023
@Robbepop Robbepop deleted the cli-add-fuel-support branch February 14, 2023 09:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants