Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove the stack-machine wasmi engine backend #818

Merged
merged 4 commits into from Dec 1, 2023
Merged

Conversation

Robbepop
Copy link
Collaborator

Closes #816.

Also remove tests testing the stack-machine wasmi engine backend which is about to be removed since those tests can no longer be run.
No post-removal clean ups performed in this commit.
@paritytech-cicd-pr
Copy link

paritytech-cicd-pr commented Nov 30, 2023

BENCHMARKS

NATIVEWASMTIME
BENCHMARKMASTERPRDIFFMASTERPRDIFFWASMTIME OVERHEAD
execute/
br_table
1.55ms 1.55ms ⚪ -0.40% 1.42ms 1.31ms 🟢 -7.66% 🟢 -16%
execute/
call/host/1
36.98µs 45.67µs 🔴 22.66% 38.29µs 66.73µs 🔴 74.06% 🟢 46%
execute/
call/rec
167.00µs 167.15µs ⚪ 0.23% 359.43µs 354.68µs 🟢 -1.36% 🔴 112%
execute/
count_until
7.45ms 7.33ms 🟢 -1.61% 7.60ms 7.51ms 🟢 -1.16% 🟢 2%
execute/
factorial/iter
225.52µs 235.25µs 🔴 5.20% 316.10µs 327.88µs 🔴 3.79% 🟢 39%
execute/
factorial/rec
675.81µs 675.91µs ⚪ 0.17% 1.35ms 1.33ms 🟢 -1.54% 🟡 97%
execute/
fibonacci/iter
1.36ms 1.36ms ⚪ 0.23% 1.18ms 1.20ms 🔴 1.73% 🟢 -12%
execute/
fibonacci/rec
6.15ms 6.16ms ⚪ 0.12% 13.05ms 13.21ms ⚪ 0.95% 🔴 114%
execute/
fibonacci/tail
1.35ms 1.35ms ⚪ 0.21% 3.70ms 3.82ms 🔴 3.18% 🔴 183%
execute/
fuse
8.11ms 7.44ms 🟢 -8.07% 12.93ms 11.39ms 🟢 -11.93% 🟡 53%
execute/
global/bump
1.33ms 1.32ms ⚪ -0.63% 1.67ms 1.59ms 🟢 -4.42% 🟢 21%
execute/
global/get_const
734.69µs 729.70µs ⚪ -0.73% 747.86µs 751.66µs ⚪ 0.52% 🟢 3%
execute/
is_even/rec
1.08ms 1.07ms ⚪ -1.24% 2.25ms 2.23ms ⚪ -0.90% 🔴 109%
execute/
memory/fill_bytes
1.13ms 1.17ms 🔴 3.68% 1.22ms 1.24ms 🔴 1.69% 🟢 5%
execute/
memory/sum_bytes
1.14ms 1.09ms 🟢 -4.21% 1.20ms 1.20ms ⚪ 0.02% 🟢 10%
execute/
memory/vec_add
2.99ms 3.17ms 🔴 5.02% 3.51ms 3.38ms 🟢 -3.56% 🟢 7%
execute/
recursive_scan
185.53µs 185.87µs ⚪ 0.19% 377.84µs 378.20µs ⚪ 0.19% 🔴 103%
execute/
recursive_trap
15.26µs 15.25µs ⚪ -0.17% 35.80µs 34.59µs 🟢 -3.89% 🔴 127%
execute/
regex_redux
594.71µs 591.89µs ⚪ -0.57% 1.02ms 1.01ms ⚪ -1.15% 🟡 70%
execute/
rev_complement
446.38µs 443.10µs ⚪ -0.62% 710.20µs 632.74µs 🟢 -10.86% 🟢 43%
execute/
tiny_keccak
349.31µs 350.96µs ⚪ 0.61% 415.99µs 388.46µs 🟢 -6.43% 🟢 11%
execute/
trunc_f2i
622.87µs 613.78µs ⚪ -1.57% 940.86µs 948.22µs ⚪ 0.71% 🟡 54%
instantiate/
wasm_kernel
54.54µs 54.76µs ⚪ 2.71% 55.61µs 56.24µs ⚪ 2.15% 🟢 3%
overhead/
call/typed/0
1.23ms 1.22ms ⚪ -1.18% 870.82µs 899.92µs 🔴 3.19% 🟢 -26%
overhead/
call/typed/16
1.57ms 1.63ms 🔴 3.71% 2.12ms 2.12ms ⚪ 0.05% 🟢 30%
overhead/
call/untyped/0
1.65ms 1.60ms 🟢 -3.01% 1.30ms 1.42ms 🔴 8.68% 🟢 -11%
overhead/
call/untyped/16
2.43ms 2.46ms ⚪ 1.32% 4.02ms 4.10ms 🔴 1.89% 🟡 67%
translate/
bz2/default
1.39ms 1.36ms 🟢 -2.41% 2.48ms 2.47ms ⚪ -0.39% 🟡 82%
translate/
bz2/fuel
1.44ms 1.40ms 🟢 -2.87% 2.63ms 2.62ms ⚪ -0.34% 🟡 87%
translate/
erc1155/default
288.02µs 276.78µs 🟢 -3.41% 478.95µs 472.50µs 🟢 -1.79% 🟡 71%
translate/
erc1155/fuel
306.82µs 296.89µs 🟢 -2.99% 509.44µs 507.25µs ⚪ -0.76% 🟡 71%
translate/
erc20/default
138.12µs 135.32µs 🟢 -1.89% 229.22µs 226.31µs 🟢 -1.51% 🟡 67%
translate/
erc20/fuel
148.78µs 142.65µs 🟢 -3.98% 239.12µs 240.73µs ⚪ 0.00% 🟡 69%
translate/
erc721/default
196.95µs 190.72µs 🟢 -3.41% 331.07µs 330.61µs ⚪ -0.62% 🟡 73%
translate/
erc721/fuel
207.43µs 199.98µs 🟢 -3.98% 348.30µs 344.87µs ⚪ -1.22% 🟡 72%
translate/
pulldown_cmark/default
3.82ms 3.75ms 🟢 -2.57% 6.43ms 6.43ms ⚪ -0.09% 🟡 71%
translate/
pulldown_cmark/fuel
3.89ms 3.81ms 🟢 -2.28% 6.75ms 6.77ms ⚪ 0.45% 🟡 78%
translate/
spidermonkey/default
0.00ns 0.00ns 🟢 -2.35% 0.00ns 0.00ns ⚪ 0.39% 🟢 0%
translate/
spidermonkey/fuel
0.00ns 0.00ns 🟢 -2.36% 0.00ns 0.00ns ⚪ -0.11% 🟢 0%
translate/
wasm_kernel/default
5.07ms 4.95ms 🟢 -2.49% 8.67ms 8.66ms ⚪ -0.20% 🟡 75%
translate/
wasm_kernel/fuel
5.23ms 5.11ms 🟢 -2.26% 9.09ms 9.04ms ⚪ -0.46% 🟡 77%

Link to pipeline

@codecov-commenter
Copy link

Codecov Report

Attention: 33 lines in your changes are missing coverage. Please review.

Comparison is base (11f51be) 81.52% compared to head (f316ddc) 80.96%.

Files Patch % Lines
crates/wasmi/src/engine/limits.rs 26.66% 11 Missing ⚠️
crates/wasmi/src/engine/regmach/bytecode/utils.rs 88.76% 10 Missing ⚠️
crates/wasmi/tests/e2e/v1/resumable_call.rs 90.24% 4 Missing ⚠️
...smi/src/engine/regmach/translator/instr_encoder.rs 83.33% 3 Missing ⚠️
crates/cli/src/context.rs 0.00% 1 Missing ⚠️
crates/cli/src/main.rs 0.00% 1 Missing ⚠️
crates/wasmi/src/engine/regmach/mod.rs 83.33% 1 Missing ⚠️
crates/wasmi/src/module/builder.rs 0.00% 1 Missing ⚠️
crates/wasmi/src/module/parser.rs 87.50% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master     #818      +/-   ##
==========================================
- Coverage   81.52%   80.96%   -0.56%     
==========================================
  Files         275      257      -18     
  Lines       25529    22321    -3208     
==========================================
- Hits        20812    18073    -2739     
+ Misses       4717     4248     -469     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

The None variant was only needed for the removed stack-machine engine backend.
@Robbepop Robbepop merged commit e2323b2 into master Dec 1, 2023
18 checks passed
@Robbepop Robbepop deleted the rf-remove-stackmach branch December 1, 2023 08:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Remove the stack-machine wasmi engine backend
3 participants