Preserve signalling bit in NaNs #87
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
eira-fransham
force-pushed
the
nan-preserving-floats
branch
from
000f7ef
to
ae6e775
Compare
pepyakin
approved these changes
Apr 24, 2018
.gitmodules
Outdated
| @@ -1,3 +1,6 @@ | |||
| [submodule "tests/spec/testsuite"] | |||
| path = tests/spec/testsuite | |||
| url = https://github.com/WebAssembly/testsuite.git | |||
| [submodule "nan-preserving-float"] | |||
There was a problem hiding this comment.
Is this is still needed? AFAICS it's already added into the repo?
There was a problem hiding this comment.
It's added as a submodule
EDIT: My mistake, I staged it wrong
There was a problem hiding this comment.
Hm, I always thought that files from the repos added via submodules are not displayed as added in a PR.
|
Ah, almost forgot about it, let's remove feature |
eira-fransham
force-pushed
the
nan-preserving-floats
branch
from
f76dad6
to
ef7620e
Compare
eira-fransham
force-pushed
the
nan-preserving-floats
branch
from
ef7620e
to
58a7e2c
Compare
|
There are a few warnings: |
|
Great! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit prevents using hardware floats for any operations that WASM specifies that we should preserve the signalling bit for. As far as I can tell, the only operations that require preservation of the signalling bit are conversion to/from int and binary negation. On x86_64 these are preserved by default since it does not distinguish between floats and integers in its calling convention, but in x87 floats are passed to and from functions on the x87 FP stack, which quietens NaNs as a result of its conversions to/from the internal 80-bit FP representation in x87.
Closes #43