Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Invoke refactoring #564

Draft
wants to merge 2 commits into
base: optimize_call_result_push
Choose a base branch
from
Draft

Conversation

chfast
Copy link
Collaborator

@chfast chfast commented Oct 1, 2020

Depends on #602.

@codecov
Copy link

codecov bot commented Oct 1, 2020

Codecov Report

Merging #564 (d43e3af) into optimize_call_result_push (90bd063) will increase coverage by 0.00%.
The diff coverage is 100.00%.

@@                    Coverage Diff                     @@
##           optimize_call_result_push     #564   +/-   ##
==========================================================
  Coverage                      99.27%   99.28%           
==========================================================
  Files                             86       86           
  Lines                          13219    13218    -1     
==========================================================
  Hits                           13123    13123           
+ Misses                            96       95    -1     
Flag Coverage Δ
rust 98.67% <ø> (+0.09%) ⬆️
spectests 89.97% <100.00%> (-0.01%) ⬇️
unittests 99.21% <100.00%> (-0.01%) ⬇️
unittests-32 99.31% <100.00%> (-0.01%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
lib/fizzy/execute.cpp 99.29% <100.00%> (-0.01%) ⬇️
bindings/rust/src/lib.rs 98.95% <0.00%> (+0.09%) ⬆️

@axic axic added the optimization Performance optimization label Oct 9, 2020
@axic axic changed the base branch from master to optimize_call_result_push November 6, 2020 17:34
@axic
Copy link
Member

axic commented Nov 6, 2020

Rebased on top of #602. Can be benchmarked too.

@axic axic force-pushed the optimize_call_result_push branch 3 times, most recently from c7d1c71 to 62311e8 Compare May 23, 2022 08:22
@chfast chfast force-pushed the optimize_call_result_push branch 2 times, most recently from 7dd0274 to 90bd063 Compare May 24, 2022 12:37
@axic
Copy link
Member

axic commented May 29, 2022

@chfast maybe this with #602 would be measurable saving? It removes the passing of func_type.

@chfast
Copy link
Collaborator Author

chfast commented May 30, 2022

@chfast maybe this with #602 would be measurable saving? It removes the passing of func_type.

Yes. This was main goal.

@axic axic added this to In progress in 0.8.0 via automation May 30, 2022
@axic axic force-pushed the invoke_optimization branch 2 times, most recently from 8aeb38f to aef6502 Compare May 30, 2022 12:53
@axic
Copy link
Member

axic commented May 30, 2022

Rebased. If we want to keep the assertion from #602, then need the last commit, which likely negates all the benefits.

@axic axic removed this from In progress in 0.8.0 Jun 28, 2022
@axic axic added this to In progress in 0.9.0 via automation Jun 28, 2022
@axic axic removed this from In progress in 0.9.0 Feb 2, 2023
@axic axic added this to In progress in 0.10.0 via automation Feb 2, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
optimization Performance optimization
Projects
0.10.0
In progress
Development

Successfully merging this pull request may close these issues.

None yet

2 participants