C API Find exported global by name #627
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #627 +/- ##
=======================================
Coverage 98.32% 98.33%
=======================================
Files 67 67
Lines 9493 9535 +42
=======================================
+ Hits 9334 9376 +42
Misses 159 159 |
gumb0
force-pushed
the
capi-find-exported-global
branch
3 times, most recently
from
4f6d0ca
to
180b52b
Compare
gumb0
force-pushed
the
capi-find-exported-global
branch
from
180b52b
to
b931896
Compare
axic
reviewed
Nov 2, 2020
| /// | ||
| /// @param instance Pointer to instance. | ||
| /// @param name The global name. NULL-terminated string. Cannot be NULL. | ||
| /// @param out_global Pointer to output struct to store found global. Cannot be NULL. |
There was a problem hiding this comment.
Is there any better best practice than prefixing it with out_?
There was a problem hiding this comment.
I'm not aware of any.
There was a problem hiding this comment.
In most case we can come up with a sentinel values. E.g. here you can have
FizzyExternalGlobal fizzy_find_exported_global(
FizzyInstance* instance, const char* name);
And then "not-found" can be represented by FizzyExternalGlobal{nullptr, FizzyValueTypeVoid}.
axic
reviewed
Nov 2, 2020
chfast
approved these changes
Nov 2, 2020
axic
approved these changes
Nov 2, 2020
gumb0
force-pushed
the
capi-find-exported-global
branch
from
b931896
to
ab47066
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.