Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Wasp dev cannot specify where will user be redirected upon the successful auth (it is hardcoded to "/") #327

Closed
matijaSos opened this issue Oct 11, 2021 · 3 comments · Fixed by #350
Labels
enhancement New feature or request good first issue Good for newcomers haskell

Comments

@matijaSos
Copy link
Contributor

Is your feature request related to a problem? Please describe.
As described above - in some cases dev might want to redirect user somewhere else.

Describe the solution you'd like
We should let developer somehow specify the desired redirection path. E.g., since we already have onAuthFailedRedirectTo as a prop of auth element, maybe we could also add onAuthSucceededRedirectTo one, and if it isn't specified then it defaults to "/".

@matijaSos matijaSos added enhancement New feature or request good first issue Good for newcomers haskell labels Oct 11, 2021
@matijaSos matijaSos changed the title Wasp dev cannot specify where will user be redirected upon successful auth (it is hardcoded to "/") Wasp dev cannot specify where will user be redirected upon the successful auth (it is hardcoded to "/") Oct 11, 2021
@vicnicius
Copy link
Contributor

vicnicius commented Oct 23, 2021

Hello @matijaSos ! I'm new to Haskell and this would be my first non-textbook task, but I'd love to give this one a try if it would be fine. I think having the onAuthFailedRedirectTo implementation will be very helpful.

@matijaSos
Copy link
Contributor Author

@vicnicius yes, for sure! I agree this is a good task to get started with the compiler and Haskell. :) @Martinsos any comments on this, how can we coordinate this with the new analyzer module coming in?

@Martinsos
Copy link
Member

Well, this might become somewhat simpler task with the new analyzer, but it will take some time till it gets integrated, so I would not wait for it -> feel free to go for it!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request good first issue Good for newcomers haskell
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants