-
-
Notifications
You must be signed in to change notification settings - Fork 1.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Only display user-defined JS lint errors #348
Comments
Awesome, thanks @vicnicius ! To solve this, we should ensure that linter lints only files present in ext-src/ in the generated project, since everything else is generated code. |
My pleasure, @Martinsos. Yes, you could probably update the web-app template to also output a .eslintignore configuration. Alternatively, maybe it would make sense for wasp to simply add a Also, on the topic of code styles, later on, wasp could provide a way for users to use a specific format for the generated code. Maybe something like:
|
@vicnicius that sounds good, any of those approaches sounds reasonable! Maybe central configuration like .eslintignore would be easier to maintain / work with, but let's see. Interesting idea about providing a way to specify the formatter, we should look into that at some point for sure. |
Hello, any problem if I work on this? My plan
I would love to implement |
@makinox Hey, sorry for the late reply. No problem at all, quite the opposite :) I like the approach and I've reviewed your PR. Let me know what you think. |
Is this still open ? |
Yes, it still is! Go for it if you want! |
Describe the bug
Based on #345.
Wasp should only inform users of lint errors they can address. Currently, it also warns about errors in the generated files.
For example, this is the current output of running the Todo tutorial code:
Notice the warnings regarding the
/src/auth/*
JS (generated) files.The text was updated successfully, but these errors were encountered: