Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Consider supporting user dev dependencies #456

Closed
faassen opened this issue Feb 10, 2022 · 1 comment
Closed

Consider supporting user dev dependencies #456

faassen opened this issue Feb 10, 2022 · 1 comment
Labels
discussion shouldfix We should do/fix this at some point

Comments

@faassen
Copy link
Contributor

faassen commented Feb 10, 2022

We perhaps want to allow the user to also create dev dependencies for the project. Or should the user just not have to care about that?

I think in an application (as opposed to a library) it doesn't really matter all that much whether things are dev dependencies or not, but this may be relevant to future application reuse, but JS developers generally have an expectation to be able to install them nonetheless.

Opt out scenario: the developer wants to create a devDependency because they want to install some dev tool into a Wasp project like a linter that's not part of Wasp

Development scenario: a developer wants to create a devDependency because they want to pull in TypeScript type definitions (maintained independently from a package), which are strictly speaking not required as main dependencies. Nonetheless, it wouldn't hurt them to install them as plain dependencies, and if you install a package that does include these type definitions you do pull them in as a main dependency...

What if a user adds in a dependency and a devDependency to the same package? Should Wasp complain? In the analysis phase or in the generator?

@Martinsos
Copy link
Member

Done with code reorg!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
discussion shouldfix We should do/fix this at some point
Projects
None yet
Development

No branches or pull requests

2 participants