Fix for .pipe method after the update to 1.7 #4
Conversation
| @@ -274,7 +277,7 @@ | |||
| done: [ fnDone, "resolve" ], | |||
| fail: [ fnFail, "reject" ], | |||
| progress: [ fnProgress, "notify" ] | |||
| }, function( handler, data ) { | |||
There was a problem hiding this comment.
Hummmm... Do we really need to complicate things by defining _each when _each is only used once here. This is a trivial process to iterate over the keys and in a for loop. I suppose this refactoring this part to be non-functional will further deviate from jQueries 1.7 source, but the positive side would be _each and line 4 can be completely removed.
There was a problem hiding this comment.
It's your call; I would suggest accepting this for now, though, and then refactoring if you decide you want to. I'm not concerned about the code size on the server, but I am concerned about the functionality =]
The only reason for doing it this way is, as you say, to remain as close as possible to jquery source.
Fix for .pipe method after the update to 1.7
|
just a note, this has now been pushed to npm at 0.1.1 |
|
thank you much! |
I guess I didn't test as well as I thought; .pipe was completely broken.
it is fixed in this pull request; hoping you can get it up really fast 'cause I need to get it to my team ASAP but need it in npm first ;-)