Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Single-command install / depend on watchexec automatically #65

Closed
passcod opened this issue Apr 22, 2017 · 7 comments
Closed

Single-command install / depend on watchexec automatically #65

passcod opened this issue Apr 22, 2017 · 7 comments
Assignees

Comments

@passcod
Copy link
Member

passcod commented Apr 22, 2017

To make v5 installable properly using the normal cargo install cargo-watch, we probably need to figure out how to either:

  • embed watchexec (preferred, as it will make sure we don't break if watchexec's interface changes)
  • install watchexec as a dependency
@passcod passcod self-assigned this Apr 22, 2017
@mattgreen
Copy link

This is an exciting development. If there's any way I can help please let me know.

@passcod
Copy link
Member Author

passcod commented Apr 26, 2017

This is now ready to release as soon as we watchexec's next release gets onto crates.io :)

@mattgreen
Copy link

This is up on crates.io now as 1.8.1.

One caveat: because watchexec is an app first and foremost, it will be hard to continue to evolve and guarantee I won't break semver via changes to to Args. Thus, in your shoes, I'd pin it to an exact version and bump it only as necessary. (I'm not looking to break the Args struct anytime soon, mind you.)

@passcod
Copy link
Member Author

passcod commented Apr 26, 2017 via email

@passcod
Copy link
Member Author

passcod commented Apr 27, 2017

Done in 5.0.0.

@passcod passcod closed this as completed Apr 27, 2017
@mattgreen
Copy link

Note: you'll want to bump to watchexec 1.8.3 to avoid a dumb bug relating to file changes being triggered in .git dirs that 1.8.1 had.

@passcod
Copy link
Member Author

passcod commented Apr 28, 2017

Ah, that's not really an issue given I build my own Args — I'd already added .git ignoring — but ooops, I just noticed a bug/typo with that commit, so I'll fix that.

(Also, you can avoid repetition by using format!("*{s}.git{s}*", s=MAIN_SEPARATOR)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants