Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade MSRV to Rust 1.69.0 #292

Closed
wants to merge 2 commits into from
Closed

Upgrade MSRV to Rust 1.69.0 #292

wants to merge 2 commits into from

Conversation

akainth015
Copy link

@akainth015 akainth015 commented Nov 30, 2023

The GH workflow check is failing with the following error.

error: package `predicates v3.0.4` cannot be built because it requires rustc 1.69.0 or newer, while the currently active rustc version is 1.67.1

This upgrades the MSRV for cargo-watch to Rust 1.69.0, which will allow predicates v3.0.4 to build in CI.

@passcod
Copy link
Member

passcod commented Nov 30, 2023

Sorry, no. That version there is the MSRV, and this repo's policy is to have at least five stable versions supported. 1.74.0 is the latest. Fortunately, that means you could change to 1.69.0 and it would be acceptable; you'll also want to change the mention in the Readme and Cargo.toml, though.

@akainth015
Copy link
Author

Thank you for pointing me in the right direction.

I have updated README.md, Cargo.toml, and check.yml. I did not find any more references to Rust 1.67.1 in the repository.

@akainth015 akainth015 changed the title Recover green checks & tests Upgrade MSRV to Rust 1.69.0 Dec 1, 2023
@passcod
Copy link
Member

passcod commented Dec 1, 2023

Looks like it's failing because of another dependency. Realistically, I'm unlikely to release a new version until the new year, at which point I'll look into these kinds of issues.

Is there a reason you wanted the build to be green?

@akainth015
Copy link
Author

Alright, in that case I will close this PR.

I use the build status as an indicator of whether the project is being maintained so I figured it may be helpful to have an accurate build status in the README.

@akainth015 akainth015 closed this Dec 4, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants