Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Upgrade nix dependency to 0.26.1, limit features #8

Merged
merged 2 commits into from
Dec 3, 2022
Merged

Upgrade nix dependency to 0.26.1, limit features #8

merged 2 commits into from
Dec 3, 2022

Conversation

rtzoeller
Copy link
Contributor

No description provided.

@rtzoeller
Copy link
Contributor Author

Supersedes #5

@passcod
Copy link
Member

passcod commented Dec 3, 2022

bors r+

bors bot added a commit that referenced this pull request Dec 3, 2022
@bors @rtzoeller
Merge #8
9628f6b 
8: Upgrade nix dependency to 0.25.1, limit features r=passcod a=rtzoeller



Co-authored-by: Ryan Zoeller <rtzoeller@rtzoeller.com>
@bors
Copy link
Contributor

bors bot commented Dec 3, 2022

Build failed:

@rtzoeller
Copy link
Contributor Author

Looks like a miss on my part - that module isn't used on Linux. Will fix.

@rtzoeller
Copy link
Contributor Author

@passcod can we try again?

@passcod
Copy link
Member

passcod commented Dec 3, 2022

bors retry

bors bot added a commit that referenced this pull request Dec 3, 2022
@bors @rtzoeller
Merge #8
69821b3 
8: Upgrade nix dependency to 0.25.1, limit features r=passcod a=rtzoeller



Co-authored-by: Ryan Zoeller <rtzoeller@rtzoeller.com>
@bors
Copy link
Contributor

bors bot commented Dec 3, 2022

Build failed:

@rtzoeller
Copy link
Contributor Author

Build failed:

* [Test on macos with Rust 1.51.0 (feat: default)](https://github.com/watchexec/command-group/actions/runs/3606837968/jobs/6078457901)

That error doesn't look particularly related to my changes, and I'm a bit skeptical. @passcod any ideas?

@passcod
Copy link
Member

passcod commented Dec 3, 2022

hmm I'll run a try from unmodified code in #9, see if that appears

@passcod
Copy link
Member

passcod commented Dec 3, 2022

Looks like it's specifically on 1.51. I might just bump this crate's msrv; I'll figure out an appropriate one later today

@rtzoeller
Copy link
Contributor Author

Looks like it's specifically on 1.51. I might just bump this crate's msrv; I'll figure out an appropriate one later today

No real preference from me, but if you end up at 1.56 or higher let me know and I will update this PR to target nix 0.26. I'm fine leaving it at 0.25 though, if you prefer an older MSRV.

@passcod
Copy link
Member

passcod commented Dec 3, 2022

Yeah I'm going with 1.60

@passcod passcod changed the title Upgrade nix dependency to 0.25.1, limit features Upgrade nix dependency to 0.26.1, limit features Dec 3, 2022
@passcod passcod enabled auto-merge (squash) December 3, 2022 14:21
@passcod passcod merged commit 6a647e9 into watchexec:main Dec 3, 2022
@rtzoeller rtzoeller mentioned this pull request Dec 3, 2022
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@passcod passcod passcod approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@rtzoeller @passcod