Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Review and upgrade filtering/ignores for intuitiveness #188

Open
passcod opened this issue Apr 11, 2021 · 7 comments
Open

Review and upgrade filtering/ignores for intuitiveness #188

passcod opened this issue Apr 11, 2021 · 7 comments
Labels
bug Something's not right! improvement Making an existing feature better, rather than a new one

Comments

@passcod
Copy link
Member

passcod commented Apr 11, 2021

This is a new catch-all issue for "ignores are confusing" so everything gets linked up here for consideration when this is tackled.

@passcod
Copy link
Member Author

passcod commented Apr 11, 2021

In general, the main idea is globset crate 👎, ignore crate 👍, but that was discussed ages ago in #14 and decided against... but that was 5 years ago, so let's review that.

@passcod
Copy link
Member Author

passcod commented Apr 29, 2021

Something that will help is to provide in the Config all of:

  • the calling working directory, that is the intuitive base for casual ignores
  • the root, where, as per git ignore syntax, / is
  • the command’s working directory, which may be different from both

defaulting to the OS-queried workdir for all of these

@passcod
Copy link
Member Author

passcod commented Jul 15, 2021

This is becoming more pressing due to breaks with globset >0.4.6, see watchexec/cargo-watch#176. Could also add workarounds just for that upgrade; will depend on what I feel like...

@dimaqq
Copy link

dimaqq commented Jul 30, 2021

[not sure if this is the right place]
.gitignore doesn't work out of the box for me:

  • .gitignore has a line /dist
  • I run watchexec -v -e js ls for testing
  • when I touch dist/bundle.js the command is re-ran


/dist means to ignore a thing named dist and anything under it, but only for top-level dist;
for example foo/bar/dist is not ignored by git in this configuration.

@passcod
Copy link
Member Author

passcod commented Jan 26, 2022

@dimaqq This is fixed as of 1.18.

I'm going to close off this issue on 2.0, as both the globset and tagged filterers will then fulfill the requirements.

@passcod passcod added bug Something's not right! improvement Making an existing feature better, rather than a new one labels Jan 26, 2022
@passcod passcod added this to the Lib 2.0 stable milestone Jan 26, 2022
@matanmarkind

This comment has been minimized.

@passcod

This comment has been minimized.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something's not right! improvement Making an existing feature better, rather than a new one
Projects
None yet
Development

No branches or pull requests

3 participants