89 extract contact us #110
Conversation
Decided to rename this from 'contact_us' to 'contact_form' due to conflicts when dealing with the singular vs plural forms of 'contact_us'. Also, right now it seems as though I can't get an app to use the rails route helper methods like _url or _path unless I call those helper methods combined with these other helper methods you get whenever you mount an engine, so you end up having to do 'wcc_contentful_app.contact_form_path' and then in the actuall application, you have to start doing things like 'main_app.root_path' wherever the engine routes and main app routes are both used. I don't know if this is just the way it has to be, but I'm thinking there's probably a better way, I just haven't seen it yet.
I included formField with section_contact_form because you can't really use the section_contact_form right now without having form_fields.
the contact-form.js will handle the contact form submissions, but for this js file to be loaded in the main application, you need to include it like this: <%= javascript_include_tag "wcc/contentful/app/application.js" %>
To generate this migration from the engine into your main application run the following command from the main app: rails wcc_contentful_app:install:migrations
wcc-contentful-app/app/controllers/wcc/contentful/app/contact_form_controller.rb
Outdated
Show resolved
Hide resolved
wcc-contentful-app/app/controllers/wcc/contentful/app/contact_form_controller.rb
Outdated
Show resolved
Hide resolved
|
|
||
| <div class="contact-panel__content"> | ||
| <!-- TODO: use route helper without needing to call directly on wcc_contentful_app --> | ||
| <%= form_tag wcc_contentful_app.contact_form_path, remote: true, data: { contact_form: 'yaddiyaddi' }, method: 'post' do %> |
...ntentful-app/db/migrate/20181029185749_create_wcc_contentful_app_contact_form_submissions.rb
Outdated
Show resolved
Hide resolved
| # frozen_string_literal: true | ||
|
|
||
| module WCC::Contentful::App | ||
| class ContactFormSubmission < ApplicationRecord |
There was a problem hiding this comment.
does this cause an error if the table doesn't exist?
wcc-contentful-app/config/routes.rb
Outdated
| @@ -2,4 +2,5 @@ | |||
|
|
|||
| WCC::Contentful::App::Engine.routes.draw do | |||
| get '/:slug', to: 'pages#show' | |||
| post '/contact_form', to: 'contact_form#create' | |||
There was a problem hiding this comment.
as: :contact_form should provide you a route helper per the comment above
jpowell
force-pushed
the
89_extract_contact_us
branch
from
ab96a66
to
371d93a
Compare
| width: 1px; | ||
| } | ||
|
|
||
| #svg--wm--resources { |
There was a problem hiding this comment.
This is a watermarkresources thing. Do we even need the layout for this email? It can be a plain text email right?
| .table_exists? 'wcc_contentful_app_contact_form_submissions' | ||
|
|
||
| ::WCC::Contentful::App::ContactFormSubmission.create!( | ||
| full_name: data['First and Last Name'], |
There was a problem hiding this comment.
I think the fact that these are hardcoded leans towards changing the implementation of the contact form fields we use here. Sorry - this is late, but Gordon and I were talking about this and remembered a conversation @frizman21 said we should go with the more simple (less configurable) approach.
See https://github.com/watermarkchurch/theporch-live/blob/develop/db/migrate/20180905202327_create_simple_mailchimp_form.ts and other relevant files... shouldn't be too much work to modify
There was a problem hiding this comment.
Let's have a conversation before we re-open this...
There was a problem hiding this comment.
@jpowell Per our conversation, please knock it out and let's move on past this task!
(including this note to close the thread)
handles inherited mail properties renamed UserMailer -> ContactMailer
jpowell
force-pushed
the
89_extract_contact_us
branch
5 times, most recently
from
48133ee
to
3297bb5
Compare
jpowell
force-pushed
the
89_extract_contact_us
branch
from
3297bb5
to
87b2cb7
Compare
WIP: Need to pull in the related specs for this work, but otherwise the code is mostly ready for review.
closes #89