Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature/new walkthroughs #530

Merged
merged 19 commits into from
Apr 27, 2023
Merged

Feature/new walkthroughs #530

merged 19 commits into from
Apr 27, 2023

Conversation

EstebanDalelR
Copy link
Member

Description

Updating the walkthrough that the user sees on installing.

Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Documentation update
  • Chore: cleanup/renaming, etc
  • RFC

Notes

Acceptance

@github-actions
Copy link

github-actions bot commented Apr 17, 2023

Context by Watermelon

@socket-security
Copy link

socket-security bot commented Apr 17, 2023

New dependency changes detected. Learn more about Socket for GitHub ↗︎


🚨 Potential security issues found in this pull request. To accept the risk, merge this PR and you will not be notified again.

Bot Commands

To ignore an alert, reply with a comment starting with @SocketSecurity ignore followed by a space separated list of package-name@version specifiers. e.g. @SocketSecurity ignore foo@1.0.0 bar@* or ignore all packages with @SocketSecurity ignore-all

  • @SocketSecurity ignore keytar@7.9.0
  • @SocketSecurity ignore esbuild@0.14.54
📜 Install scripts

Install scripts are run when the package is installed. The majority of malware in npm is hidden in install scripts.

Packages should not be running non-essential scripts during install and there are often solutions to problems people solve with install scripts that can be run at publish time instead.

Package Script field Source
keytar@7.9.0 (added) install package.json via @vscode/vsce@2.19.0
esbuild@0.14.54 (added) postinstall package.json
🫣 Native code

Contains native code which could be a vector to obscure malicious code, and generally decrease the likelihood of reproducible or reliable installs.

Ensure that native code bindings are expected. Consumers may consider pure JS and functionally similar alternatives to avoid the challenges and risks associated with native code bindings.

Package Location Source
keytar@7.9.0 (added) binding.gyp package.json via @vscode/vsce@2.19.0
Pull request alert summary
Issue Status
Install scripts ⚠️ 2 issues
Native code ⚠️ 1 issue
Bin script shell injection ✅ 0 issues
Unresolved require ✅ 0 issues
Invalid package.json ✅ 0 issues
HTTP dependency ✅ 0 issues
Git dependency ✅ 0 issues
Potential typo squat ✅ 0 issues
Known Malware ✅ 0 issues
Telemetry ✅ 0 issues
Protestware/Troll package ✅ 0 issues

📊 Modified Dependency Overview:

➕ Added Package Capability Access +/- Transitive Count Publisher
@types/vscode@1.77.0 None +0 types
@vscode/extension-telemetry@0.5.2 eval, network, filesystem, shell, environment +0 lramos15
@types/vscode-webview@1.57.1 None +0 types
typescript@4.9.5 network, filesystem, shell, environment +0 typescript-bot
glob@7.2.3 filesystem, environment +10 isaacs
@types/git-url-parse@9.0.1 None +0 types
husky@8.0.3 None +0 typicode
@types/glob@7.2.0 None +1 types
@vscode/vsce@2.19.0 eval, network, filesystem, shell, environment +104 vscode-bot
@types/mocha@9.1.1 None +0 types
@vscode/test-electron@2.3.0 network, filesystem, shell, environment +19 vscode-bot
git-url-parse@11.6.0 eval +20 ionicabizau
mocha@9.2.2 filesystem, environment +80 juergba
esbuild@0.14.54 network, filesystem, shell, environment +21 evanw
eslint@7.32.0 eval, filesystem, shell, environment +107 eslintbot
@vscode/codicons@0.0.31 filesystem +0 miguelsolorio
@typescript-eslint/parser@4.33.0 eval, filesystem, shell, environment +137 jameshenry
axios@0.26.1 network, environment +1 jasonsaayman
@typescript-eslint/eslint-plugin@4.33.0 eval, filesystem, shell, environment +141 jameshenry

@sonarcloud
Copy link

sonarcloud bot commented Apr 17, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants