This repository has been archived by the owner on Mar 12, 2024. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 12
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
Context by WatermelonGitHub PRsNo results found :( Jira TicketsNo results found :( Slack ThreadsNo results found :( |
Context by WatermelonGitHub PRsNo results found :( Jira TicketsNo results found :( Slack ThreadsNo results found :( |
const sampleReq = { | ||
body: { | ||
dailyStats: [ | ||
/*... your sample data with at least 10 items ...*/ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ah, thanks chatGPT
}); | ||
|
||
describe("handler", () => { | ||
const mockCreate = jest.fn(); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I worry about using mocks due to the speed our API and requirements are changing
|
||
const expectedRecords = [ | ||
{ | ||
fields: { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Does it?
EstebanDalelR
approved these changes
Apr 14, 2023
Please add husky |
Merged
This was referenced May 16, 2023
Merged
This was referenced May 17, 2023
This was referenced Jun 20, 2023
Merged
This was referenced Aug 8, 2023
Merged
Closing in favor of the new tests |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Please take a look at how I've set up the environment for running test (use npm test, to test it)
If it looks good, I'll go ahead and write tests for all routes.