Skip to content
This repository has been archived by the owner on Mar 12, 2024. It is now read-only.

Add conditional if the count passes 500 #311

Merged
merged 5 commits into from
Sep 27, 2023

Conversation

baristaGeek
Copy link
Collaborator

Description

This fix helps us keep trying monetization experiments. We were always showing the count and not inviting people to go to the billing link (Calendly).

Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Documentation update
  • Chore: cleanup/renaming, etc
  • RFC

Notes

This is how it looks
Screen Shot 2023-09-22 at 4 14 14 PM
on my private personal repo

Acceptance

@vercel
Copy link

vercel bot commented Sep 22, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
watermelon ✅ Ready (Inspect) Visit Preview 💬 Add feedback Sep 26, 2023 5:52pm

@watermelon-copilot-for-code-review
Copy link

watermelon-copilot-for-code-review bot commented Sep 22, 2023

The 5 commits in the Pull Request indicate that there were changes made to the logic that determines whether to show the count or invite users to pay. Commit 1 added a condition that checks if the count exceeds 500 before showing the invitation. Commit 2 replaced all indexed information with an invitation to pay. Commit 3 removed the logic from the markdown helper. Commit 4 removed a console log. Commit 5 unwrapped the commenting logic from being below the threshold and replaced the comment with a billing link using an if statement that doesn't wrap the commenting logic. Overall, these changes aim to fix the issue of not inviting users to the billing link and enable monetization experiments.

GitHub PRs

Click here to login to Jira
Click here to login to Confluence
Click here to login to Slack
No results found in Notion Pages :(

No results found in Linear Tickets :(

Click here to login to Asana
watermelon is an open repo and Watermelon will serve it for free.
🍉🫶

…nt with billing link with an if statement that doesn't wrap the commenting logic.
@EstebanDalelR
Copy link
Member

closes #308

@baristaGeek baristaGeek merged commit ef7dc57 into dev Sep 27, 2023
3 checks passed
@baristaGeek baristaGeek deleted the bugfix/bugfix-not-showing-billing-link branch September 27, 2023 19:11
@watermelon-copilot-for-code-review

@baristaGeek baristaGeek restored the bugfix/bugfix-not-showing-billing-link branch November 10, 2023 16:08
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants