Skip to content
This repository has been archived by the owner on Mar 12, 2024. It is now read-only.

Feature/comment specific line diffs #331

Merged
merged 13 commits into from
Oct 26, 2023

Conversation

baristaGeek
Copy link
Collaborator

@baristaGeek baristaGeek commented Oct 18, 2023

Description

This PR uses the console log detection function to comment on the specific diff in the specific file containing the console log.

To do so, we tell OpenAI to also return the code line itself, and then get the code line in the position of the diff (not the actual file) which is what Octokit needs.

Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Documentation update
  • Chore: cleanup/renaming, etc
  • RFC

Acceptance

@vercel
Copy link

vercel bot commented Oct 18, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
watermelon ✅ Ready (Inspect) Visit Preview 💬 Add feedback Oct 26, 2023 10:27pm

@watermelon-copilot-for-code-review
Copy link

watermelon-copilot-for-code-review bot commented Oct 18, 2023

WatermelonAI Summary

The 13 commits in this Pull Request indicate that the team is working on commenting on specific diff lines that contain console logs. Initially, they added hello world examples in Python, C++, and Rust for testing purposes. They then made updates and fixes to the code and implemented the functionality to detect console logs and comment on them using the Octokit route. They intentionally sent a PR with console logs to test the functionality, but later removed the console logs and test hello worlds. There were also some minor changes made, such as fixing a typo and changing the event from REQUEST_CHANGES to COMMENT. Overall, this PR introduces a new feature that allows for commenting on specific lines in the code diff that contain console logs.

GitHub PRs

Click here to login to Jira
Click here to login to Confluence
Click here to login to Slack
Notion Pages deactivated by baristaGeek
Linear Tickets deactivated by baristaGeek
Click here to login to Asana
watermelon is an open repo and Watermelon will serve it for free.
🍉🫶

const indiviudalLine = openAIResult.line;

console.log("additionsHaveConsoleLog", addtionsHaveConsoleLog);
console.log("indiviudalLine", indiviudalLine);

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

getConsoleLogPosition - This file contains at least one console log. Please remove any present.

@@ -0,0 +1,3 @@
fn main() {
println!("Hello World!");
}

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

getConsoleLogPosition - This file contains at least one console log. Please remove any present.

@baristaGeek baristaGeek changed the title [TEST] - Feature/comment specific line diffs Feature/comment specific line diffs Oct 24, 2023
This was referenced Oct 25, 2023
utils/actions/detectConsoleLogs.ts Outdated Show resolved Hide resolved
utils/actions/detectConsoleLogs.ts Show resolved Hide resolved
utils/actions/detectConsoleLogs.ts Show resolved Hide resolved
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants