Skip to content
This repository has been archived by the owner on Mar 12, 2024. It is now read-only.

Bugfix: Calling detecConsoleLogs in missing control flow + Fix indexing issue for the single line file border-case #346

Merged

Conversation

baristaGeek
Copy link
Collaborator

Description

We were not commenting detected console logs on the line diffs of mono-line files. This PR fixes that border case.

Look at the test comments on https://github.com/watermelontools/watermelon/pull/345/files for reference.

Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Documentation update
  • Chore: cleanup/renaming, etc
  • RFC

Acceptance

@vercel
Copy link

vercel bot commented Oct 27, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
watermelon ✅ Ready (Inspect) Visit Preview 💬 Add feedback Oct 27, 2023 10:03pm

@watermelon-copilot-for-code-review

WatermelonAI Summary

The first commit and the pull request are both titled "Fix indexing issue for the single line file border-case." The commit message and PR body explain that there was a problem with commenting console logs on single-line files, and this commit fixes that issue. Looking at the test comments on the corresponding link provided gives a better understanding of the changes made. The type of change is a bug fix, and the acceptance criteria have been met.

GitHub PRs

Click here to login to Jira
Click here to login to Confluence
Click here to login to Slack
Notion Pages deactivated by baristaGeek
Linear Tickets deactivated by baristaGeek
Click here to login to Asana
watermelon is an open repo and Watermelon will serve it for free.
🍉🫶

@baristaGeek baristaGeek changed the title Fix indexing issue for the single line file border-case Bugfix: Fix indexing issue for the single line file border-case Oct 27, 2023
@baristaGeek baristaGeek changed the title Bugfix: Fix indexing issue for the single line file border-case Bugfix: Calling detecConsoleLogs in missing control flow + Fix indexing issue for the single line file border-case Oct 27, 2023
Copy link
Member

@EstebanDalelR EstebanDalelR left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks for extracting!

@EstebanDalelR EstebanDalelR merged commit 8d8c315 into dev Oct 30, 2023
3 checks passed
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants