Implement optional fuzzy search #11
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Using the super fast fuzzysearch module and a new option we can now perform a fuzzy search for emojis. This is espicaly usefull if one don't know the english spelling of some keywords that well.
|
Wooo this feature looks nice! Could you take a look at the error on travis CI? It would be great if you could fix it 😺 |
|
Should be all good now. Missed a space... |
|
A w e s o m e ! I will add a test case for the fuzzy search later(maybe this weekend), or you could add it if you have an interest in it 😼 |
added 2 commits
September 30, 2016 07:47
Before, only keywords where fuzzy searched.
|
I added some tests. While writing them I realized that fuzzy search didn't search in the emoji name, only the keywords. I fixed that too. |
|
Great!! That's the benefit of the test we can receive. Let me merge this and ship it immediately 😆 Thanks for putting this together and following up hardly |
|
This is shipped as v0.3.0 🎉 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Using the super fast fuzzysearch module and a new option we can now perform a fuzzy search for emojis. This is espicaly usefull if one don't know the english spelling of some keywords that well.