Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

CLI doesn't play nice with Yield #39

Closed
AlexDarigan opened this issue Nov 16, 2019 · 3 comments
Closed

CLI doesn't play nice with Yield #39

AlexDarigan opened this issue Nov 16, 2019 · 3 comments
Assignees
@AlexDarigan
Labels
bug Something isn't working resolved For features and refactors that got added

Comments

@AlexDarigan
Copy link
Collaborator

The CLI doesn't wait for yields in tests. Requires fix.
@AlexDarigan
Copy link
Collaborator Author

Thinking about this it might be related to process not working correctly therefore none of the timers though since this is a CLI focused thing. So it basically skips yields.

@AlexDarigan
Copy link
Collaborator Author

Another potential issue is the dataflow. Maybe the intro of the CLI on top of the runner is giving the yields somewhere to go back to.

@AlexDarigan
Copy link
Collaborator Author

AlexDarigan commented Nov 17, 2019 •
edited
Loading

Solved by #5f04ea9

@AlexDarigan AlexDarigan self-assigned this Nov 17, 2019
@AlexDarigan AlexDarigan added the bug Something isn't working label Nov 17, 2019
@AlexDarigan AlexDarigan added the resolved For features and refactors that got added label Feb 7, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@AlexDarigan AlexDarigan

Labels
bug Something isn't working resolved For features and refactors that got added
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@AlexDarigan