fix ancient Vagrantfile & fix imports #18
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cmluciano
reviewed
Mar 29, 2018
| sudo mv /tmp/gopath.sh /etc/profile.d/gopath.sh | ||
| sudo chmod 0755 /etc/profile.d/gopath.sh | ||
| export PATH="#{GOPATH}/bin:\$PATH" | ||
| EOT |
There was a problem hiding this comment.
Just a heredoc for adding that text to gopath.sh
Vagrantfile
Outdated
| go build | ||
| go test ./... | ||
| go install | ||
|
|
||
| # Make sure the gopath is usable by vagrant | ||
| sudo chown -R -f vagrant:vagrant $SRCROOT | ||
| sudo chown -R -f vagrant:vagrant #{GOPATH} | ||
| sudo chown -R -f vagrant:vagrant #{GOPATH} |
There was a problem hiding this comment.
This may need to be done sooner since we try to use things within the GOPATH on prior lines
|
|
||
| echo "Ready for development. Begin with cd $GOPATH/#{PACKAGE_PATH}" | ||
|
|
||
| SCRIPT | ||
|
|
||
| Vagrant.configure(2) do |config| | ||
| config.vm.box = "chef/ubuntu-12.04" | ||
| config.vm.box = "ubuntu/trusty64" |
There was a problem hiding this comment.
Can we use generic/ubuntu1604 instead since it supports more providers?
david-shepard
changed the title
|
Ok Vagrant works fine and can build but these imports seem to be breaking |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A bunch of fixes to get the Vagrantfile working and fix the imports so it works with the latest version of packer (1.2.2)