fix for values < 1 #1
Conversation
now works with values < 1 too
src/leaflet.nauticscale.js
Outdated
| scale.style.width = Math.round(this.options.maxWidth * (nauticalMiles / maxNauticalMiles)) - 10 + 'px'; | ||
| scale.innerHTML = nauticalMiles + ' nm'; | ||
| scale.style.width = Math.round(this.options.maxWidth * (nauticalMiles / maxNauticalMiles)) + 'px'; | ||
| scale.innerHTML = nauticalMiles + ' nmi'; |
There was a problem hiding this comment.
Hmmm... this is now an interesting point.
There are some abbreviation for the Nautical Mile.
Maybe we should make the configurable depending of the needs of the user.
Wikipedia show us the Problem: https://en.wikipedia.org/wiki/Nautical_mile#Unit_symbol
We should use a Default and if someone want to have something else, it should be possible to do this over an option:
map.addControl(new L.Control.ScaleNautic({
metric: true,
imperial: true,
nautic: true,
nauticUnit: "nmi"
}));
There was a problem hiding this comment.
yes, good idea. i didn't even consider this.
There was a problem hiding this comment.
hey @obama
can we split this ?
remove this and the I will accept the pull request
after that we can add the nauticUnit as an Option ;)
like that?
|
the Travis CI fails because some phantomjs thing or so? |
|
yes there was a problem with travis |
now works with values < 1 too