Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Screenshot returning nil? #4

Closed
watzon opened this issue Oct 29, 2019 · 3 comments · Fixed by #10
Closed

Screenshot returning nil? #4

watzon opened this issue Oct 29, 2019 · 3 comments · Fixed by #10

Comments

@watzon
Copy link
Owner

watzon commented Oct 29, 2019

Putting this here so I can show progress. cc: @bararchy

Apparently there is a situation where screenshot might return nil

Error in Cross-Site Scripting entry_point http://vulnerable-bank.com/app_v3_banking.php: Expected Hash for #[](key : String), not Nil (Exception)

  from /usr/share/crystal/src/json/any.cr:104:7 in '[]'

  from lib/marionette/src/marionette/browser.cr:594:14 in 'screenshot'

  from /usr/share/crystal/src/fiber.cr:255:3 in 'run'

  from ???
@watzon
Copy link
Owner Author

watzon commented Oct 29, 2019

It's possible that 23144c8 will fix this, but I wasn't able to reproduce using http://vulnerable-bank.com/app_v3_banking.php so I can't test for sure

@bararchy
Copy link
Contributor

👍 thanks :)

@bararchy
Copy link
Contributor

Seems this issue is still in effect

Expected Hash for #[](key : String), not Nil (Exception)
  from /usr/share/crystal/src/json/any.cr:104:7 in '[]'
  from lib/marionette/src/marionette/browser.cr:594:14 in 'screenshot'

I think it might not actually be the URL as it just might be the state the browser is in.
I'll try and produce more helpful info regarding this occurrence.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants