Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

There is a lot of problems with unzip dependancy #14

Closed
svycka opened this issue Feb 19, 2015 · 4 comments
Closed

There is a lot of problems with unzip dependancy #14

svycka opened this issue Feb 19, 2015 · 4 comments

Comments

@svycka
Copy link
Contributor

svycka commented Feb 19, 2015

Many of those are fixed in this EvanOxfeld/node-unzip#64 but it cannot be merged without modifications. So maybe would be good idea to change lib to something new? or use that PR there is a npm module unzip2 from that branch.
@wavded
Copy link
Owner

wavded commented Feb 19, 2015

Thanks for bringing this to my attention. Are you aware of how likely a merge is into unzip to address these? unzip2 seems to address, but will it be maintained?

@svycka
Copy link
Contributor Author

svycka commented Feb 19, 2015

I don't think so. But maybe you could ask the author of the PR.

@svycka
Copy link
Contributor Author

svycka commented Feb 19, 2015

Merge is impossible without modifications and PR is half year old. Not so much hope I guess. But I don't know, everything is possible :D

@svycka svycka mentioned this issue Feb 24, 2015
Merged
@wavded
Copy link
Owner

wavded commented Feb 24, 2015

Merged!

@wavded wavded closed this as completed Feb 24, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@wavded @svycka