Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix bug in archives with uncompressed files #64

Open
wants to merge 29 commits into
base: master
Choose a base branch
from

Conversation

glebdmitriew
Copy link

This pull request fixes unzipping for uncompressed files which size is not known in the header. This fixes issues: #41, #32 and may fix #56 and #52.

@missinglink
Copy link

This is amazing @glebdmitriew and fixes the numerous reported 'Error: invalid signature' issues.

Can we please get this merged upstream @EvanOxfeld?

@silverwind
Copy link

👍 This is awesome, also fixes #63. Great find @missinglink! The PR would probably need some work regarding README and package.json changes, from the looks of it.

@pietercolpaert
Copy link

Will this get merged eventually?

@mbatista
Copy link

mbatista commented Dec 4, 2014

I would really love if this was merged. It basically saved my project!

@missinglink
Copy link

FYI to anyone using this fork of the module, you will need to change your code due to this commit which landed a few days ago glebdmitriew@10c0c29 or you will get Error: Invalid Package: expected node-unzip-2 but found unzip errors from fresh installs.

The change is pretty simple and should look something like this: https://github.com/geopipes/geonames-stream/pull/8/files

If you are currently linking to the github tarball you can test if you have this issue by executing npm install, no error, no problem ;)

@silverwind
Copy link

Maybe someone should start a clean fork 😇

@qraynaud
Copy link

@glebdmitriew : can you push your version on npm as unzip2 ? Since this package looks dead it would be cool…

@seagullua
Copy link

We added the unzip2 as npm package
npm install unzip2

https://www.npmjs.com/package/unzip2

@Oneway102
Copy link

Yes http://github.com/glebdmitriew/node-unzip-2 can resolve the problem.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Cannot unzip this file