Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Black Sea In Reflection Probe #15

Closed
GeorgeDziov opened this issue May 22, 2018 · 3 comments
Closed

Black Sea In Reflection Probe #15

GeorgeDziov opened this issue May 22, 2018 · 3 comments
Labels

Comments

@GeorgeDziov
Copy link

GeorgeDziov commented May 22, 2018

I really hate posting issues but I just noticed ocean is black in objects with PBR materials. It's no biggie for me but I thought I must notify developer about this. I also tried changing ocean material properties but alas no luck.

2018-05-22 18 23 54

EDIT: Zero fesnel kinda fixes the ocean but it's zero fresnel so... nope, scratch that.

@huwb
Copy link
Contributor

huwb commented May 23, 2018

Thanks for notifying me of this. Thats quite a bug!

I can repro this on my end as well. I'm pretty sure its to do with the fact that I'm using _LightColor0 directly in the shader, which seems to be not ok for reflection probes. I have another issue also related to lighting so I can look at both at the same time. I'll post back when i have news. Thanks for raising!

huwb added a commit that referenced this issue May 29, 2018
@huwb
Copy link
Contributor

huwb commented May 29, 2018

It looks like Dizzy & Midda found the issue while looking into another bug. It looks fine to me now! Closing but let me know if you still have issues. Thanks!

@GeorgeDziov
Copy link
Author

GeorgeDziov commented May 30, 2018

That's insane, thanks a ton! Works like Swiss Clock! Pity Crest Ocean works only in 2018.1 now but I'll adapt my projects.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants