Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Support multi-camera scenarios #540

Open
huwb opened this issue Jun 12, 2020 · 5 comments
Open

Support multi-camera scenarios #540

huwb opened this issue Jun 12, 2020 · 5 comments
Labels
Enhancement

Comments

@huwb
Copy link
Contributor

huwb commented Jun 12, 2020 •
edited
Loading

We've had a few requests recently for supporting multiple simultaneous cameras.

This probably involves at least:

  • Removing the global OceanRenderer.Instance singleton. Probably have a lookup function with viewpoint as input?
  • Ocean geometry would need to know which ocean their rendering
  • Should boats and stuff pick the nearest viewpoint?
  • More..?
@daleeidd
Copy link
Collaborator

The underwater environmental lighting component probably won't work well with this. Casting our own shadows instead of decreasing the light intensity could be a solution.

@Timelapser
Copy link

This would be great to make split-screen multiplayer possible.

huwb added a commit that referenced this issue Aug 8, 2020
@huwb
#540 - explore what multiple ocean instances would mean
73c3128 
Once i started pulling on the thread i could not stop. This branch should work like
before iwth one ocean, there are a few issues before it will support multiple instances.

Questions / problems that arose:

Lod data resolution should be global setting, right now taken from one instance
Validation gets passed "AnyInstance" in a few places, is this ok?
RenderData.Validate - uses any instance
RegisterLodDataClipSurface - this sets per-ocean data on MPB. might be tricky to fix..
How to connect underwater effect to ocean instance?
How to connect underwater environment lighting with ocean instance?
Debuggui always takes first instance of ocean, shall we make this selectable?
OceanChunkRenderer.OnWillRenderObject - tiles will need Layer so it only goes in one camera??

tag @daleeidd @moosichu in case this is of interest
@huwb huwb mentioned this issue Sep 12, 2020
Open
8 tasks
@daleeidd daleeidd mentioned this issue Nov 4, 2020
Closed
@huwb
Copy link
Contributor Author

huwb commented May 1, 2021

This is still on the list, but I still don't have a timeline for when we might look at it as our bandwidth is absorbed by the day to day support and fixes and etc, and a small amount of feature dev.

We're hoping to increase our bandwidth through sponsorship and i wanted to mention that once here in case there is interest in supporting us: https://github.com/sponsors/wave-harmonic

@jessome
Copy link

jessome commented Aug 9, 2022 •
edited
Loading

What are the implications here for single ocean with multiple cameras pointed at it?

I'm planning to switch to Crest, but in my vessel simulator I've got multiple simultaneous camera views. A common use-case is for us to have three cameras around the coxswain's seat looking Forward, Port, and Starboard to approximate the windows of our tiny boat's cabin.

Edit: Having tried it, it seems multiple cameras fight over the underwater effect, but otherwise seem to cooperate pretty well for my use case.

@daleeidd
Copy link
Collaborator

Edit: Having tried it, it seems multiple cameras fight over the underwater effect, but otherwise seem to cooperate pretty well for my use case.

Underwater will support multiple cameras in the next version.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Enhancement
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
4 participants
@huwb @daleeidd @jessome @Timelapser